Skip to content

Remove interval property from Credential Offer #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 120 commits into
base: main
Choose a base branch
from

Conversation

forkimenjeckayang
Copy link
Collaborator

@forkimenjeckayang forkimenjeckayang commented Jun 10, 2025

This pull request addresses the recent specification change in OpenID for Verifiable Credential Issuance (OID4VCI), where the interval property was moved from the Credential Offer to the Deferred Credential Response.

To align with the updated specification, this change removes the interval property from the PreAuthorizedCode model, which is part of the Credential Offer payload.

Changes:

  • Removed the interval field and its corresponding getter and setter methods from PreAuthorizedCode.java.
  • Updated the equals() and hashCode() methods in PreAuthorizedCode.java to reflect the removal of the interval property.
  • Verified that no existing tests were impacted by this change, ensuring the continued stability of the test suite.

Closes keycloak#39294
Closes #43

tnorimat and others added 30 commits May 28, 2025 19:52
… ID Token returned by the OP

Closes keycloak#39885

Signed-off-by: Pedro Igor <[email protected]>
userSessionCountForRealm was changed for userSessionCountForClient

Closes keycloak#40060

Signed-off-by: Markov Gleb <[email protected]>
Bumps [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) from 8.32.1 to 8.33.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.33.0/packages/typescript-eslint)

---
updated-dependencies:
- dependency-name: typescript-eslint
  dependency-version: 8.33.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.15.23 to 22.15.26.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-version: 22.15.26
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Updated translation for German

Language: de

Updated translation for German

Language: de

Updated translation for German

Language: de

Updated translation for German

Language: de

Updated translation for German

Language: de

Updated translation for German

Language: de

Co-authored-by: Andreas Hunkeler <[email protected]>
Co-authored-by: Hosted Weblate <[email protected]>
Co-authored-by: Robin <[email protected]>
Signed-off-by: Andreas Hunkeler <[email protected]>
Signed-off-by: Hosted Weblate <[email protected]>
Signed-off-by: Robin <[email protected]>

* Updated translation for Japanese

Language: ja

Co-authored-by: Hosted Weblate <[email protected]>
Co-authored-by: Takashi Norimatsu <[email protected]>
Signed-off-by: Hosted Weblate <[email protected]>
Signed-off-by: Takashi Norimatsu <[email protected]>

* Updated translation for Catalan

Language: ca

Co-authored-by: Ecron <[email protected]>
Co-authored-by: Hosted Weblate <[email protected]>
Signed-off-by: Ecron <[email protected]>
Signed-off-by: Hosted Weblate <[email protected]>

* Updated translation for Italian

Language: it

Co-authored-by: Hosted Weblate <[email protected]>
Co-authored-by: albanobattistella <[email protected]>
Signed-off-by: Hosted Weblate <[email protected]>
Signed-off-by: albanobattistella <[email protected]>

* Updated translation for Spanish

Language: es

Updated translation for Spanish

Language: es

Updated translation for Spanish

Language: es

Co-authored-by: Hernan Lopez <[email protected]>
Co-authored-by: Hosted Weblate <[email protected]>
Signed-off-by: Hernan Lopez <[email protected]>
Signed-off-by: Hosted Weblate <[email protected]>

* Updated translation for French

Language: fr

Updated translation for French

Language: fr

Updated translation for French

Language: fr

Updated translation for French

Language: fr

Co-authored-by: Hosted Weblate <[email protected]>
Co-authored-by: Sylvain Pichon <[email protected]>
Signed-off-by: Hosted Weblate <[email protected]>
Signed-off-by: Sylvain Pichon <[email protected]>

* Updated translation for Georgian

Language: ka

Co-authored-by: Hosted Weblate <[email protected]>
Co-authored-by: Temuri Doghonadze <[email protected]>
Signed-off-by: Hosted Weblate <[email protected]>
Signed-off-by: Temuri Doghonadze <[email protected]>

---------

Signed-off-by: Andreas Hunkeler <[email protected]>
Signed-off-by: Hosted Weblate <[email protected]>
Signed-off-by: Robin <[email protected]>
Signed-off-by: Takashi Norimatsu <[email protected]>
Signed-off-by: Ecron <[email protected]>
Signed-off-by: albanobattistella <[email protected]>
Signed-off-by: Hernan Lopez <[email protected]>
Signed-off-by: Sylvain Pichon <[email protected]>
Signed-off-by: Temuri Doghonadze <[email protected]>
Co-authored-by: Andreas Hunkeler <[email protected]>
Co-authored-by: Robin <[email protected]>
Co-authored-by: Takashi Norimatsu <[email protected]>
Co-authored-by: Ecron <[email protected]>
Co-authored-by: albanobattistella <[email protected]>
Co-authored-by: Hernan Lopez <[email protected]>
Co-authored-by: Sylvain Pichon <[email protected]>
Co-authored-by: Temuri Doghonadze <[email protected]>
fixes: keycloak#40139

Signed-off-by: Erik Jan de Wit <[email protected]>
Closes keycloak#39817

Signed-off-by: Somin Park <[email protected]>
Signed-off-by: Alexander Schwartz <[email protected]>
Co-authored-by: Alexander Schwartz <[email protected]>
Current messages_ru.properties file is a full copy of base/messages_en.properties file but with translated values

Closes keycloak#40108

Signed-off-by: Anton Petrov <[email protected]>
dependabot bot and others added 7 commits June 10, 2025 10:16
Bumps [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) from 8.33.0 to 8.34.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.34.0/packages/typescript-eslint)

---
updated-dependencies:
- dependency-name: typescript-eslint
  dependency-version: 8.34.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.30.0 to 0.31.0.
- [Release notes](https://github.com/aquasecurity/trivy-action/releases)
- [Commits](aquasecurity/trivy-action@0.30.0...0.31.0)

---
updated-dependencies:
- dependency-name: aquasecurity/trivy-action
  dependency-version: 0.31.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.28.18 to 3.28.19.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@ff0a06e...fca7ace)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.28.19
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Closes keycloak#40380

Signed-off-by: Bruno Oliveira da Silva <[email protected]>
@IngridPuppet IngridPuppet marked this pull request as draft June 10, 2025 14:44
dependabot bot and others added 10 commits June 10, 2025 14:42
Bumps [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) from 5.4.0 to 5.4.1.
- [Release notes](https://github.com/prettier/eslint-plugin-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-plugin-prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/eslint-plugin-prettier@v5.4.0...v5.4.1)

---
updated-dependencies:
- dependency-name: eslint-plugin-prettier
  dependency-version: 5.4.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [rollup](https://github.com/rollup/rollup) from 4.41.1 to 4.42.0.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v4.41.1...v4.42.0)

---
updated-dependencies:
- dependency-name: rollup
  dependency-version: 4.42.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [simple-git](https://github.com/steveukx/git-js/tree/HEAD/simple-git) from 3.27.0 to 3.28.0.
- [Release notes](https://github.com/steveukx/git-js/releases)
- [Changelog](https://github.com/steveukx/git-js/blob/main/simple-git/CHANGELOG.md)
- [Commits](https://github.com/steveukx/git-js/commits/[email protected]/simple-git)

---
updated-dependencies:
- dependency-name: simple-git
  dependency-version: 3.28.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.15.26 to 24.0.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-version: 24.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…keycloak#40382)

Scope CSS media query to only apply when both OS and Keycloak theme are dark.
This prevents referencing undefined CSS variables when OS prefers dark mode
but Keycloak uses light theme.

Closes keycloak#40135

Signed-off-by: Takuya <[email protected]>
Closes keycloak#39866

Signed-off-by: Martin Bartoš <[email protected]>
Signed-off-by: Alexander Schwartz <[email protected]>
Co-authored-by: Alexander Schwartz <[email protected]>
Co-authored-by: Alexander Schwartz <[email protected]>
)

Bumps [manusa/actions-setup-minikube](https://github.com/manusa/actions-setup-minikube) from 2.13.1 to 2.14.0.
- [Release notes](https://github.com/manusa/actions-setup-minikube/releases)
- [Commits](manusa/actions-setup-minikube@v2.13.1...v2.14.0)

---
updated-dependencies:
- dependency-name: manusa/actions-setup-minikube
  dependency-version: 2.14.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
rmartinc and others added 8 commits June 11, 2025 11:51
* Translated using Weblate (Portuguese (Brazil))

Translation: Keycloak/Theme base/admin
Translate-URL: https://hosted.weblate.org/projects/keycloak/theme-baseadmin/pt_BR/

Updated translation for Portuguese (Brazil)

Language: pt_BR

Updated translation for Portuguese (Brazil)

Language: pt_BR

Updated translation for Portuguese (Brazil)

Language: pt_BR

Updated translation for Portuguese (Brazil)

Language: pt_BR

Updated translation for Portuguese (Brazil)

Language: pt_BR

Co-authored-by: Felipe Zorzo <[email protected]>
Co-authored-by: Gabriel Santos <[email protected]>
Co-authored-by: Hosted Weblate <[email protected]>
Signed-off-by: Felipe Zorzo <[email protected]>
Signed-off-by: Gabriel Santos <[email protected]>
Signed-off-by: Hosted Weblate <[email protected]>

* Updated translation for German

Language: de

Updated translation for German

Language: de

Updated translation for German

Language: de

Updated translation for German

Language: de

Co-authored-by: Alexander Schwartz <[email protected]>
Co-authored-by: Andreas Hunkeler <[email protected]>
Co-authored-by: Hosted Weblate <[email protected]>
Co-authored-by: Robin <[email protected]>
Signed-off-by: Alexander Schwartz <[email protected]>
Signed-off-by: Andreas Hunkeler <[email protected]>
Signed-off-by: Hosted Weblate <[email protected]>
Signed-off-by: Robin <[email protected]>

* Updated translation for Russian

Language: ru

Updated translation for Russian

Language: ru

Co-authored-by: Alexander Schwartz <[email protected]>
Co-authored-by: An On <[email protected]>
Co-authored-by: Hosted Weblate <[email protected]>
Signed-off-by: Alexander Schwartz <[email protected]>
Signed-off-by: An On <[email protected]>
Signed-off-by: Hosted Weblate <[email protected]>

* Updated translation for Catalan

Language: ca

Co-authored-by: Ecron <[email protected]>
Co-authored-by: Hosted Weblate <[email protected]>
Signed-off-by: Ecron <[email protected]>
Signed-off-by: Hosted Weblate <[email protected]>

* Updated translation for Italian

Language: it

Co-authored-by: Giovanni Quarella <[email protected]>
Co-authored-by: Hosted Weblate <[email protected]>
Signed-off-by: Giovanni Quarella <[email protected]>
Signed-off-by: Hosted Weblate <[email protected]>

---------

Signed-off-by: Felipe Zorzo <[email protected]>
Signed-off-by: Gabriel Santos <[email protected]>
Signed-off-by: Hosted Weblate <[email protected]>
Signed-off-by: Alexander Schwartz <[email protected]>
Signed-off-by: Andreas Hunkeler <[email protected]>
Signed-off-by: Robin <[email protected]>
Signed-off-by: An On <[email protected]>
Signed-off-by: Ecron <[email protected]>
Signed-off-by: Giovanni Quarella <[email protected]>
Co-authored-by: Felipe Zorzo <[email protected]>
Co-authored-by: Gabriel Santos <[email protected]>
Co-authored-by: Alexander Schwartz <[email protected]>
Co-authored-by: Andreas Hunkeler <[email protected]>
Co-authored-by: Robin <[email protected]>
Co-authored-by: An On <[email protected]>
Co-authored-by: Ecron <[email protected]>
Co-authored-by: Giovanni Quarella <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet