forked from keycloak/keycloak
-
Notifications
You must be signed in to change notification settings - Fork 2
[OID4VCI] Always Return Array for Credential Responses #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
forkimenjeckayang
wants to merge
114
commits into
main
Choose a base branch
from
issue-39283
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes keycloak#40012 Signed-off-by: Takashi Norimatsu <[email protected]>
closes keycloak#40014 Signed-off-by: Takashi Norimatsu <[email protected]>
Fixes keycloak#40039 Signed-off-by: Thomas Darimont <[email protected]>
…L IDP provider Closes keycloak#39596 Signed-off-by: rmartinc <[email protected]>
Closes keycloak#39950 Signed-off-by: Martin Kanis <[email protected]>
closes: keycloak#40032 Signed-off-by: Steve Hawkins <[email protected]>
… ID Token returned by the OP Closes keycloak#39885 Signed-off-by: Pedro Igor <[email protected]>
closes keycloak#40016 Signed-off-by: Takashi Norimatsu <[email protected]>
closes keycloak#40050 Signed-off-by: Takashi Norimatsu <[email protected]>
closes keycloak#40052 Signed-off-by: Takashi Norimatsu <[email protected]>
closes keycloak#40054 Signed-off-by: Takashi Norimatsu <[email protected]>
closes keycloak#40056 Signed-off-by: Takashi Norimatsu <[email protected]>
userSessionCountForRealm was changed for userSessionCountForClient Closes keycloak#40060 Signed-off-by: Markov Gleb <[email protected]>
Bumps [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) from 8.32.1 to 8.33.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.33.0/packages/typescript-eslint) --- updated-dependencies: - dependency-name: typescript-eslint dependency-version: 8.33.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.15.23 to 22.15.26. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 22.15.26 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…r to revert back OK Closes keycloak#40049 Signed-off-by: rmartinc <[email protected]>
Closes keycloak#39781 Signed-off-by: rmartinc <[email protected]>
Closes keycloak#39987 Signed-off-by: Anchels <[email protected]>
…exist (keycloak#40089) Closes keycloak#40024 Signed-off-by: Ryan Emerson <[email protected]>
closes keycloak#40104 Signed-off-by: mposolda <[email protected]>
* Updated translation for German Language: de Updated translation for German Language: de Updated translation for German Language: de Updated translation for German Language: de Updated translation for German Language: de Updated translation for German Language: de Co-authored-by: Andreas Hunkeler <[email protected]> Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Robin <[email protected]> Signed-off-by: Andreas Hunkeler <[email protected]> Signed-off-by: Hosted Weblate <[email protected]> Signed-off-by: Robin <[email protected]> * Updated translation for Japanese Language: ja Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Takashi Norimatsu <[email protected]> Signed-off-by: Hosted Weblate <[email protected]> Signed-off-by: Takashi Norimatsu <[email protected]> * Updated translation for Catalan Language: ca Co-authored-by: Ecron <[email protected]> Co-authored-by: Hosted Weblate <[email protected]> Signed-off-by: Ecron <[email protected]> Signed-off-by: Hosted Weblate <[email protected]> * Updated translation for Italian Language: it Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: albanobattistella <[email protected]> Signed-off-by: Hosted Weblate <[email protected]> Signed-off-by: albanobattistella <[email protected]> * Updated translation for Spanish Language: es Updated translation for Spanish Language: es Updated translation for Spanish Language: es Co-authored-by: Hernan Lopez <[email protected]> Co-authored-by: Hosted Weblate <[email protected]> Signed-off-by: Hernan Lopez <[email protected]> Signed-off-by: Hosted Weblate <[email protected]> * Updated translation for French Language: fr Updated translation for French Language: fr Updated translation for French Language: fr Updated translation for French Language: fr Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Sylvain Pichon <[email protected]> Signed-off-by: Hosted Weblate <[email protected]> Signed-off-by: Sylvain Pichon <[email protected]> * Updated translation for Georgian Language: ka Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Temuri Doghonadze <[email protected]> Signed-off-by: Hosted Weblate <[email protected]> Signed-off-by: Temuri Doghonadze <[email protected]> --------- Signed-off-by: Andreas Hunkeler <[email protected]> Signed-off-by: Hosted Weblate <[email protected]> Signed-off-by: Robin <[email protected]> Signed-off-by: Takashi Norimatsu <[email protected]> Signed-off-by: Ecron <[email protected]> Signed-off-by: albanobattistella <[email protected]> Signed-off-by: Hernan Lopez <[email protected]> Signed-off-by: Sylvain Pichon <[email protected]> Signed-off-by: Temuri Doghonadze <[email protected]> Co-authored-by: Andreas Hunkeler <[email protected]> Co-authored-by: Robin <[email protected]> Co-authored-by: Takashi Norimatsu <[email protected]> Co-authored-by: Ecron <[email protected]> Co-authored-by: albanobattistella <[email protected]> Co-authored-by: Hernan Lopez <[email protected]> Co-authored-by: Sylvain Pichon <[email protected]> Co-authored-by: Temuri Doghonadze <[email protected]>
fixes: keycloak#40139 Signed-off-by: Erik Jan de Wit <[email protected]>
…ingIssuer() as it was before closes keycloak#40106 Signed-off-by: mposolda <[email protected]>
…ak#39589) Closes keycloak#39587 Signed-off-by: Alexander Schwartz <[email protected]>
…k#40029) Signed-off-by: stianst <[email protected]>
) Closes keycloak#39785 Signed-off-by: Alexander Schwartz <[email protected]>
Closes keycloak#39817 Signed-off-by: Somin Park <[email protected]> Signed-off-by: Alexander Schwartz <[email protected]> Co-authored-by: Alexander Schwartz <[email protected]>
Closes keycloak#40034 Signed-off-by: Anchels <[email protected]>
Closes keycloak#40027 Signed-off-by: Anchels <[email protected]>
Current messages_ru.properties file is a full copy of base/messages_en.properties file but with translated values Closes keycloak#40108 Signed-off-by: Anton Petrov <[email protected]>
closes: keycloak#40099 Signed-off-by: Steve Hawkins <[email protected]>
Signed-off-by: Gunnar Scherf <[email protected]>
Bumps [lint-staged](https://github.com/lint-staged/lint-staged) from 16.0.0 to 16.1.0. - [Release notes](https://github.com/lint-staged/lint-staged/releases) - [Changelog](https://github.com/lint-staged/lint-staged/blob/main/CHANGELOG.md) - [Commits](lint-staged/lint-staged@v16.0.0...v16.1.0) --- updated-dependencies: - dependency-name: lint-staged dependency-version: 16.1.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js) from 9.27.0 to 9.28.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/commits/v9.28.0/packages/js) --- updated-dependencies: - dependency-name: "@eslint/js" dependency-version: 9.28.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint](https://github.com/eslint/eslint) from 9.27.0 to 9.28.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v9.27.0...v9.28.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 9.28.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [react-hook-form](https://github.com/react-hook-form/react-hook-form) from 7.56.4 to 7.57.0. - [Release notes](https://github.com/react-hook-form/react-hook-form/releases) - [Changelog](https://github.com/react-hook-form/react-hook-form/blob/master/CHANGELOG.md) - [Commits](react-hook-form/react-hook-form@v7.56.4...v7.57.0) --- updated-dependencies: - dependency-name: react-hook-form dependency-version: 7.57.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Closes keycloak#40339 Signed-off-by: rmartinc <[email protected]>
Bumps [mocha](https://github.com/mochajs/mocha) from 11.5.0 to 11.6.0. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/main/CHANGELOG.md) - [Commits](mochajs/mocha@v11.5.0...v11.6.0) --- updated-dependencies: - dependency-name: mocha dependency-version: 11.6.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) from 8.33.0 to 8.34.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.34.0/packages/typescript-eslint) --- updated-dependencies: - dependency-name: typescript-eslint dependency-version: 8.34.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…n databasechangelog Closes keycloak#38602 Signed-off-by: vramik <[email protected]>
IngridPuppet
approved these changes
Jun 10, 2025
services/src/main/java/org/keycloak/protocol/oid4vc/model/CredentialResponse.java
Outdated
Show resolved
Hide resolved
Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.30.0 to 0.31.0. - [Release notes](https://github.com/aquasecurity/trivy-action/releases) - [Commits](aquasecurity/trivy-action@0.30.0...0.31.0) --- updated-dependencies: - dependency-name: aquasecurity/trivy-action dependency-version: 0.31.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.28.18 to 3.28.19. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@ff0a06e...fca7ace) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 3.28.19 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…is found Closes keycloak#39923 Signed-off-by: Pedro Igor <[email protected]>
Closes keycloak#40380 Signed-off-by: Bruno Oliveira da Silva <[email protected]>
…attribute Closes keycloak#40270 Signed-off-by: Pedro Igor <[email protected]>
Bumps [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) from 5.4.0 to 5.4.1. - [Release notes](https://github.com/prettier/eslint-plugin-prettier/releases) - [Changelog](https://github.com/prettier/eslint-plugin-prettier/blob/main/CHANGELOG.md) - [Commits](prettier/eslint-plugin-prettier@v5.4.0...v5.4.1) --- updated-dependencies: - dependency-name: eslint-plugin-prettier dependency-version: 5.4.1 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [rollup](https://github.com/rollup/rollup) from 4.41.1 to 4.42.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v4.41.1...v4.42.0) --- updated-dependencies: - dependency-name: rollup dependency-version: 4.42.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [simple-git](https://github.com/steveukx/git-js/tree/HEAD/simple-git) from 3.27.0 to 3.28.0. - [Release notes](https://github.com/steveukx/git-js/releases) - [Changelog](https://github.com/steveukx/git-js/blob/main/simple-git/CHANGELOG.md) - [Commits](https://github.com/steveukx/git-js/commits/[email protected]/simple-git) --- updated-dependencies: - dependency-name: simple-git dependency-version: 3.28.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.15.26 to 24.0.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 24.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…keycloak#40382) Scope CSS media query to only apply when both OS and Keycloak theme are dark. This prevents referencing undefined CSS variables when OS prefers dark mode but Keycloak uses light theme. Closes keycloak#40135 Signed-off-by: Takuya <[email protected]>
closes: keycloak#40099 Signed-off-by: Steve Hawkins <[email protected]>
Closes keycloak#39866 Signed-off-by: Martin Bartoš <[email protected]> Signed-off-by: Alexander Schwartz <[email protected]> Co-authored-by: Alexander Schwartz <[email protected]> Co-authored-by: Alexander Schwartz <[email protected]>
…rsion Closes keycloak#39723 Signed-off-by: Alexander Schwartz <[email protected]>
) Bumps [manusa/actions-setup-minikube](https://github.com/manusa/actions-setup-minikube) from 2.13.1 to 2.14.0. - [Release notes](https://github.com/manusa/actions-setup-minikube/releases) - [Commits](manusa/actions-setup-minikube@v2.13.1...v2.14.0) --- updated-dependencies: - dependency-name: manusa/actions-setup-minikube dependency-version: 2.14.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Closes keycloak#39283 Signed-off-by: forkimenjeckayang <[email protected]>
fa2996b
to
fe22773
Compare
Closes keycloak#40402 Signed-off-by: rmartinc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Keycloak OID4VCI implementation to comply with the latest OID4VCI specification, ensuring that the
credentials
field in the credential response is always an array (even for a single credential).CredentialResponse Model:
credentials
is always a list of credential objects.Issuer Endpoint:
Closses Ticket
transaction_id
keycloak/keycloak#39283