Excluding AKISerialNumber test on JDK8 until fix is merged #5215
Conversation
This fix is in the dev branch, but is not yet merged into the master branch. This fix will likely be merged shortly after the April 2024 release. Signed-off-by: Adam Farley <[email protected]>
For awareness, typically we merge into master then cherrypick the commit to the release branch. There would be no delay in merging into master, as we do not code freeze AQAvit repos, since we tag and branch, development is not blocked/frozen during release periods. |
|
Ah, that makes sense. Thanks for explaining. 😃 |
|
In this instance then, should I cherry pick in the other direction and open a new PR so the commit ID is the same? |
No, in this instance, I have already merged your PR to the release branch. We will proceed to merge this PR to master once it gets a second approval. I mentioned it for awareness going forward for future PRs. And, we do not always want to / need to cherrypick commits to the release branch even though it makes sense to commit it to the master branch. |
This fix is in the dev branch, but is not yet merged into the master branch. This fix will likely be merged shortly after the April 2024 release.