Skip to content

Update excluded JFR tests in JDK8 ProblemList with proper links to upstream JBS issues #5122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

roberttoyonaga
Copy link
Contributor

I've created upstream PRs for fixing TestCompilerCompile and TestCompilerPhase. The PR for TestCompilerCompile has been merged, but will take a while to backport (because I need to do it for 22, 21, 17, 11, then finally 8). Since, it might take some time to backport and the fix only affects the test, the best temporary solution is probably to keep the test excluded. So for now I'd just like to update the ProblemList links to point to the correct JBS issues so people can understand why these tests must be disabled.

@roberttoyonaga
Copy link
Contributor Author

The ECA check is failing. Should I manually sign it, or am I already covered since I work at Red Hat?

@smlambert
Copy link
Contributor

I have been told there is a way to indicate in your Eclipse profile that you work for a member company (Red Hat) and would not need to explicitly sign the ECA. I have not successfully seen how that is done, so I signed the ECA following these instructions (https://adoptium.net/docs/eca-sign-off/).

@roberttoyonaga
Copy link
Contributor Author

I have been told there is a way to indicate in your Eclipse profile that you work for a member company (Red Hat) and would not need to explicitly sign the ECA. I have not successfully seen how that is done, so I signed the ECA following these instructions (https://adoptium.net/docs/eca-sign-off/).

Thanks @smlambert! I'll follow those instructions.

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @roberttoyonaga !

@smlambert smlambert merged commit 32fc295 into adoptium:master Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants