Skip to content

Support custom target with variation #4568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2023
Merged

Support custom target with variation #4568

merged 2 commits into from
May 9, 2023

Conversation

llxia
Copy link
Contributor

@llxia llxia commented May 8, 2023

resolves: #4495

@llxia
Copy link
Contributor Author

llxia commented May 8, 2023 •
edited
Loading

@llxia llxia marked this pull request as ready for review May 9, 2023 15:09
@llxia llxia requested review from LongyuZhang and smlambert May 9, 2023 15:09
smlambert
smlambert approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LongyuZhang
LongyuZhang approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit 6ff1db2 into adoptium:master May 9, 2023
@sophia-guo
Copy link
Contributor

Does #4572 means this PR is unnecessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

@LongyuZhang LongyuZhang LongyuZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jdk_custom_0 issue
4 participants
@llxia @sophia-guo @smlambert @LongyuZhang