Skip to content

Remove JavaTestRunner #4864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
llxia opened this issue Nov 10, 2023 · 2 comments · Fixed by #4888 or #4898
Closed

Remove JavaTestRunner #4864

llxia opened this issue Nov 10, 2023 · 2 comments · Fixed by #4888 or #4898

Comments

@llxia
Copy link
Contributor

llxia commented Nov 10, 2023

JavaTestRunner and JavatestUtil are similar file.

And most of tests are using JavatestUtil except

aqa-tests/jck/jck.mk

Line 129 in 4a1eca1

JCK_CMD_TEMPLATE = $(JAVA_TO_TEST) -Djvm.options=$(Q)$(JVM_OPTIONS)$(Q) -Dother.opts=$(Q)$(OTHER_OPTS)$(Q) -cp $(TEST_ROOT)/jck/jtrunner/bin JavaTestRunner resultsRoot=$(REPORTDIR) testRoot=$(TEST_ROOT) jckRoot=$(JCK_ROOT) jckversion=$(JCK_VERSION) spec=$(SPEC) configAltPath=$(CONFIG_ALT_PATH) $(APPLICATION_OPTIONS)

https://github.com/search?q=repo%3Aadoptium%2Faqa-tests%20JCK_CMD_TEMPLATE&type=code

I think if we update these two tests to run via JavatestUtil, we can remove JavaTestRunner.
@smlambert
Copy link
Contributor

Yes, that was the next step in the 'evolution' of this automation (stripping away unneeded layers).

@llxia
Copy link
Contributor Author

llxia commented Nov 23, 2023

@annaibm can you take a look at this one? Thanks

annaibm added a commit to annaibm/aqa-tests that referenced this issue Nov 24, 2023
@annaibm
Update tests to use JavatestUtil
343d15b 
-This code updates the custom tests to use JavatestUtil instead of JavaTestRunner.

resolves: adoptium#4864

Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm added a commit to annaibm/aqa-tests that referenced this issue Nov 24, 2023
@annaibm
Update tests to use JavatestUtil
793be2e 
-This code updates the custom tests to use JavatestUtil instead of JavaTestRunner.

resolves: adoptium#4864

Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm added a commit to annaibm/aqa-tests that referenced this issue Nov 24, 2023
@annaibm
Update tests to use JavatestUtil
b86e4dc 
-This code updates the custom tests to use JavatestUtil instead of JavaTestRunner.

resolves: adoptium#4864

Signed-off-by: Anna Babu Palathingal <[email protected]>
annaibm added a commit to annaibm/aqa-tests that referenced this issue Nov 24, 2023
@annaibm
Update tests to use JavatestUtil
0ad00dd 
- This code updates the custom tests to use JavatestUtil instead of JavaTestRunner.
- Removes JavaTestRunner file

resolves: adoptium#4864

Signed-off-by: Anna Babu Palathingal <[email protected]>
@annaibm annaibm mentioned this issue Nov 24, 2023
Merged
@annaibm annaibm mentioned this issue Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@smlambert @llxia