Skip to content

feat: splunk client #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Feb 13, 2025
Merged

feat: splunk client #579

merged 23 commits into from
Feb 13, 2025

Conversation

langswei
Copy link
Contributor

@langswei langswei commented Feb 5, 2025

Splunk client to give the option for CDN logs as a data source.

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

#578

Copy link

github-actions bot commented Feb 6, 2025

This PR will trigger a minor release when merged.

Copy link
Member

@solaris007 solaris007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this, good stuff. a few comments.

@solaris007 solaris007 changed the title Splunk client feat: splunk client Feb 6, 2025
@solaris007 solaris007 added the enhancement New feature or request label Feb 11, 2025
langswei added a commit that referenced this pull request Feb 12, 2025
…591)

In #579 comments, @solaris007 suggested handling queries as static
files, external to the javascript source. The getPrompt helper function
was mentioned as a model. This PR will create an updated release of the
spacecat-shared-utils package which can be referenced by #579.

---------

Co-authored-by: Dominique Jäggi <[email protected]>
solaris007 pushed a commit that referenced this pull request Feb 12, 2025
# [@adobe/spacecat-shared-utils-v1.31.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-utils-v1.30.4...@adobe/spacecat-shared-utils-v1.31.0) (2025-02-12)

### Features

* util for reading .query static files, modeled after getPrompt ([#591](#591)) ([af3700d](af3700d)), closes [#579](#579) [#579](#579)
@langswei langswei requested a review from solaris007 February 13, 2025 14:17
Copy link
Member

@solaris007 solaris007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff :) thank you for your contribution. cosmetic comment added.

@langswei langswei merged commit 474888f into main Feb 13, 2025
6 checks passed
@langswei langswei deleted the splunk branch February 13, 2025 18:59
solaris007 pushed a commit that referenced this pull request Feb 13, 2025
# @adobe/spacecat-shared-splunk-client-v1.0.0 (2025-02-13)

### Features

* splunk client ([#579](#579)) ([474888f](474888f)), closes [#578](#578)
@solaris007
Copy link
Member

🎉 This PR is included in version @adobe/spacecat-shared-splunk-client-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants