-
Notifications
You must be signed in to change notification settings - Fork 8
feat: splunk client #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: splunk client #579
Conversation
This PR will trigger a minor release when merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for this, good stuff. a few comments.
…591) In #579 comments, @solaris007 suggested handling queries as static files, external to the javascript source. The getPrompt helper function was mentioned as a model. This PR will create an updated release of the spacecat-shared-utils package which can be referenced by #579. --------- Co-authored-by: Dominique Jäggi <[email protected]>
# [@adobe/spacecat-shared-utils-v1.31.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-utils-v1.30.4...@adobe/spacecat-shared-utils-v1.31.0) (2025-02-12) ### Features * util for reading .query static files, modeled after getPrompt ([#591](#591)) ([af3700d](af3700d)), closes [#579](#579) [#579](#579)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff :) thank you for your contribution. cosmetic comment added.
🎉 This PR is included in version @adobe/spacecat-shared-splunk-client-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Splunk client to give the option for CDN logs as a data source.
Please ensure your pull request adheres to the following guidelines:
Related Issues
#578