-
Notifications
You must be signed in to change notification settings - Fork 6
feat: a11y assistive opportunity (SITES-31943) #907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dianaapredaa
wants to merge
82
commits into
main
Choose a base branch
from
SITES-31943
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR will trigger a minor release when merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessibility - Assistive technology is incompatible on site
Overview
This PR extends the existing accessibility audit worker (from feat-a11y-audit-worker) by adding individual opportunity creation functionality. The enhancement creates URL-specific accessibility opportunities alongside the existing site-wide reports.
Key Features Added
Enhanced Accessibility Handler (src/accessibility/handler.js)
Added Step 2c: Integration of individual opportunity creation in processAccessibilityOpportunities()
New Opportunity Template (src/accessibility/utils/report-oppty.js)
Added: createAccessibilityAssistiveOpportunity() - Creates 'a11y-assistive' template opportunities
Purpose: Template for individual accessibility opportunities with assistive technology focus
Enhanced Constants (src/accessibility/utils/constants.js)
Added: new constant for 'a11y-assistive' accessibility opportunity IDs in order to track specific issue types
Purpose: Defines which accessibility issues should generate individual opportunities
Related Issues: https://jira.corp.adobe.com/browse/SITES-31943