fix Issue #8953- "Localizing package metadata in Extension Manager"

src/extensibility/ExtensionManagerView.js

@@ -28,7 +28,8 @@
 define(function (require, exports, module) {
     "use strict";
 
-    var Strings                   = require("strings"),
+    var _                         = require("thirdparty/lodash"),
+        Strings                   = require("strings"),
         StringUtils               = require("utils/StringUtils"),
         ExtensionManager          = require("extensibility/ExtensionManager"),
         registry_utils            = require("extensibility/registry_utils"),
@@ -236,6 +237,21 @@ define(function (require, exports, module) {
             context.isCompatible = context.isCompatibleLatest = true;
         }
 
+        // Check if extension metadata contains localized content.
+        var lang            = brackets.getLocale(),
+            shortLang       = lang.split("-")[0];
+        [shortLang, lang].forEach(function (locale) {
+            if (info.metadata["package-i18n"] !== undefined &&
+                    info.metadata["package-i18n"].hasOwnProperty(locale)) {
+                // only overlay specific properties with the localized values
+                ['title', 'description', 'homepage', 'keywords'].forEach(function (prop) {
+                    if (info.metadata["package-i18n"][locale].hasOwnProperty(prop)) {
+                        info.metadata[prop] = info.metadata["package-i18n"][locale][prop];
+                    }
+                });
+            }
+        });
+
         if (info.metadata.description !== undefined) {
             info.metadata.shortdescription = StringUtils.truncate(info.metadata.description, 200);
         }
@@ -249,9 +265,6 @@ define(function (require, exports, module) {
         context.allowInstall = context.isCompatible && !context.isInstalled;
 
         if (Array.isArray(info.metadata.i18n) && info.metadata.i18n.length > 0) {
-            var lang      = brackets.getLocale(),
-                shortLang = lang.split("-")[0];
-
             context.translated = true;
             context.translatedLangs =
                 info.metadata.i18n.map(function (value) {

src/extensions/samples/LocalizationExample/README.md

@@ -48,7 +48,7 @@ Move this plugin to the extensions\user\ folder to run the plugin. It will add a
 
 * main.js – loads the Strings module for the plugin and uses mustache to localize html content
 
-* package.json - add the translation languages as in the example: `"i18n: ["en", "fr" ]`
+* package.json - add the translation languages as in the example: `"i18n: ["en", "fr" ]`.  Also, add any localized metadata for displayed metadata in the Extension Manager, as in the example: `"fr": { "title": "localized title" }`.
 
 * strings.js – uses i18n to load a strings.js file in the nls folder
 

src/extensions/samples/LocalizationExample/package.json

@@ -12,5 +12,11 @@
     "i18n": [
         "en", 
         "fr" 
-    ]
+    ],
+    "package-i18n": {
+        "fr": {
+            "title": "Localisation Exemple",
+            "description": "Un guide sur la façon de localiser votre poste."
+        }
+    }
 }