Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

[Themes] Revert theme settings when cancelling out of the themes dialog #8405

Merged
merged 3 commits into from
Jul 16, 2014
Merged

[Themes] Revert theme settings when cancelling out of the themes dialog #8405

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9c78b8
Revert theme settings when canceling out of the settings dialog
MiguelCastillo Jul 15, 2014
7beb4e6
Corrected jslint error
MiguelCastillo Jul 15, 2014
ad89720
Merge branch 'master' into themes-8390
MiguelCastillo Jul 16, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/view/ThemeSettings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,10 @@ define(function (require, exports, module) {
prefs.set(setting, newSettings[setting]);
});
}
else if (id === "cancel") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be: } else if (id === "cancel") {

// Make sure we revert any changes to theme selection
prefs.set("themes", currentSettings.themes);
}
});
}

Expand Down