This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Add Function.prototype.bind polyfill see #7951 #7956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
eager to see this land! by looks of it, this may fix the other part of my problem as well. |
| @@ -246,6 +246,7 @@ module.exports = function (grunt) { | |||
| specs : '<%= meta.specs %>', | |||
| /* Keep in sync with test/SpecRunner.html dependencies */ | |||
| vendor : [ | |||
| 'test/polyfills.js', | |||
There was a problem hiding this comment.
@WebsiteDeveloper, perhaps it makes sense to mention the issue #7951 in a comment here and that it should not be required once we update to a PhantomJS with not-so-outdated JS engine.
|
@WebsiteDeveloper Done with review. Just need to add a comment mentioned by @busykai |
|
Thanks. Merging. |
redmunds
added a commit
that referenced
this pull request
May 28, 2014
Add Function.prototype.bind polyfill see #7951
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@redmunds
#7951