Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Remove brackets.app.abortQuit checks #7885

Merged
merged 1 commit into from
May 21, 2014
Merged

Remove brackets.app.abortQuit checks #7885

merged 1 commit into from
May 21, 2014

Conversation

le717
Copy link
Contributor

@le717 le717 commented May 19, 2014

Removes the two year old brackets.app.abortQuit checks added before the switch to the CEF3 shell. Fixes #7883.

@busykai
Copy link
Contributor

busykai commented May 20, 2014

@le717, if you don't mind, could you please sign Brackets CLA? Otherwise this PR cannot be merged.

@le717
Copy link
Contributor Author

le717 commented May 20, 2014

I signed it already, as can be checked here. The Travis build failed because there were too many GitHub API requests. Do I need to sign it again?

@busykai
Copy link
Contributor

busykai commented May 20, 2014

You're right -- haven't read the actual server response. No, you don't to sign it again.

@busykai
Copy link
Contributor

busykai commented May 20, 2014

@le717, Brackets does not run only in brackets-shell, there are other uses as well, so it is slightly more complicated...

@JeffryBooher, in principle, there should be no problem merging this request. Other brackets.app calls are not protected this way, so an implementation of application should implement entire contract anyways. I'm thinking perhaps #6605 should be changed to actually define and document the interface in javascript (currently it could only be found in adobe/brackets-shell and nowhere in adobe/brackets itself).

@redmunds
Copy link
Contributor

Looks good. Merging.

redmunds added a commit that referenced this pull request May 21, 2014
Remove `brackets.app.abortQuit` checks
@redmunds redmunds merged commit 2f13054 into adobe:master May 21, 2014
@le717 le717 deleted the remove-abortquit-check branch May 22, 2014 23:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove brackets.app.abortQuit check
3 participants