Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Changes to build.prop file to support Jenkins jobs #6076

Merged
merged 7 commits into from
Dec 4, 2013

Conversation

jasonsanjose
Copy link
Member

Change grunt build-prop task to

  1. work when on a detached head (i.e. during jenkins build)
  2. use bash compatible property key names
  3. include shell git info

Example output:

brackets_build_version=0.34.0-10744
brackets_www_commits=10744
brackets_www_sha=a1addee49066ec75f89edccb882a39a7de3c6f10
brackets_www_branch=jasonsanjose/build-prop-keys
brackets_shell_commits=1068
brackets_shell_sha=2f543d2b7b8cdfebd66aac843b147881bd8c2597
brackets_shell_branch=release

This lets us parameterize Jenkins jobs for both master and release branches so that both branches can be built from the same job. Without this change, we would need to make copies of the current build jobs since they are hard coded to master.

@ghost ghost assigned ingorichter Nov 25, 2013
@kkarlesk
Copy link
Contributor

@ingorichter Can you take a look at this please?

@ghost ghost assigned couzteau Nov 26, 2013
@jasonsanjose
Copy link
Member Author

See also #5776

@ghost ghost assigned ingorichter Dec 3, 2013
@jasonsanjose
Copy link
Member Author

Back to @ingorichter. Thanks!

ingorichter added a commit that referenced this pull request Dec 4, 2013
Changes to build.prop file to support Jenkins jobs
@ingorichter ingorichter merged commit 88dd296 into master Dec 4, 2013
@ingorichter
Copy link
Contributor

Looks good. Merged!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants