Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Remove welcomeProjectManager cleanup code #3248

Closed
wants to merge 2 commits into from
Closed

Remove welcomeProjectManager cleanup code #3248

wants to merge 2 commits into from

Conversation

albertxing
Copy link
Contributor

Refers to issue #2823

  • Passes all unit tests
  • Passes ProjectManager integration test

Searched through all occurrences of "welcomeProjectsFixed" and found only the two local values.

peterflynn and others added 2 commits March 25, 2013 18:47
…Win,

if you drag onto the editor area) - Revert 8f35d64's change enabling
CodeMirror dragDrop. This problem is the reason we had dragDrop disabled
in the first place.
Clean up welcomeProjectsFixed code - Issue #2823
@albertxing
Copy link
Contributor Author

Out of context now.

@albertxing albertxing closed this Mar 29, 2013
@TomMalbran
Copy link
Contributor

@albertxing Next time you try and pull this fix, check into making a branch for each pull request instead of requesting directly from master, since branches don't need much maintenance unless there are merge issues, will only have your commits, and are a lot easier to handle multiple pull requests.

@albertxing
Copy link
Contributor Author

Hi, thanks for the suggestion.
Do you have a bit of time to look over the two commits and see if they are sufficient for this issue?

I'm still quite new to large projects.

@TomMalbran
Copy link
Contributor

Yes, your commit is enough to fix this issue (the second one). The other commit, shouldn't be added on your next pull request, but that is fixed having the local repository up to date with the github repository and then creating a branch from it.

Check the wiki if you need more information, specially: https://github.com/adobe/brackets/wiki/How-to-Hack-on-Brackets

@albertxing
Copy link
Contributor Author

Thanks, I was wondering why peterflynn's commit showed up. I'll be more careful.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants