This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Improve Live Dev test reliability #3134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
Looks good, and definitely improves the tests. Thanks! |
gruehle
added a commit
that referenced
this pull request
Mar 16, 2013
Improve Live Dev test reliability
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LiveDevelopment status getting set to STATUS_ACTIVE happens after the Inspector becomes connected, so this is a better event to wait for. This removes the need to blindly wait an extra second just to be safe.
Also, this will detect the case that LiveDevelopment stays in the "Initializing..." state.
@gruehle Signed up to code review