Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Added the ruby html extension .erb to be reconized as html #3083

Closed
wants to merge 1 commit into from
Closed

Added the ruby html extension .erb to be reconized as html #3083

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 9, 2013

Added the .erb to the html case of languages.json. This to recognise the ruby on rails extension .erb as html.

@pthiess
Copy link
Contributor

pthiess commented Mar 12, 2013

Community pull request - open to anyone to grab.

@jbalsas
Copy link
Contributor

jbalsas commented Mar 14, 2013

@madebytrolls I was going to get this in, but I also saw #3122 lined up, which may address some issue with ruby. After that pull request settles in, you could map .html.erb to html and .erb to Ruby. Is it possible that you could benefit from this? If so, I'd recommend to close this one and create a new one with that differentiation in mind once #3122 gets merged. (I have no experience with ruby... @DennisKehrig could you chime in on this?).

@DennisKehrig
Copy link
Contributor

@madebytrolls That would indeed be a bit better, since .erb isn't necessarily HTML - for instance, I have a mail template in one project called "summary.text.plain.erb" alongside "summary.text.html.erb". I think Ruby is a reasonable fallback for .erb, and it would work exactly as you described. :)

@ghost
Copy link
Author

ghost commented Mar 14, 2013

Agreed

@jbalsas
Copy link
Contributor

jbalsas commented Mar 29, 2013

@madebytrolls Support for complex file extensions just landed in #3285. Just saying, in case you're interested in giving this another try ;)

@kidwm
Copy link
Contributor

kidwm commented Apr 25, 2013

@jbalsas I'm using Sprint 23 on Mac OS X, but it did not works on any file names like index.html.erb or layout.erb in RoR.

@TomMalbran
Copy link
Contributor

It looks like the support was added, but the extension wasn't added to the languages.json file to make the parsing work.

@peterflynn
Copy link
Member

Yes -- if you look at the status at the top of the pull request, it was never actually merged. The new APIs added in Sprint 23 should make it possible to write a new pull request that we can merge -- but no one has had the time to do that yet.

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants