This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fix bug #1243 (Input fields don't work in dialogs) #1722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rlier fix that let keystrokes through to the textfield, but auto-closed the dialog when certain chars were typed. Now we only close the dialog if the char typed could not have been intended as text input.
| var inFormField = ($(e.target).filter(":input").length > 0), | ||
| inTextArea = (e.target.tagName === "TEXTAREA"); | ||
|
|
||
| if (e.which === KeyEvent.DOM_VK_RETURN && !inTextArea) { // enter key in single-line text input still dismisses |
There was a problem hiding this comment.
Nice to allow enter keys to create new lines.
ghost
assigned
RaymondLim
added a commit
that referenced
this pull request
Sep 27, 2012
Fix bug #1243 (Input fields don't work in dialogs)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug #1243 (Input fields don't work in dialogs)
Improves on an earlier fix (pull #1325), which let keystrokes through to the textfield but still auto-closed the dialog when certain chars were typed. Now we only close the dialog if the char typed could not have been intended as text input.