This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Changed WebPlatform License to MDN License and respective strings #13447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabh95
requested review from
nethip,
marcelgerber,
petetnt,
ficristo and
swmitra
|
I skimmed through the changes and they seems good.
|
|
The above mentioned locales with no urls.js there is no getting started page defined in sample, so probably this might be the reason of not creating the urls.js |
|
Yeah, what I was trying to say, if you need the text translated everywhere those languages will not be. |
|
@ficristo I just did replace of Web Platform to MDN, there are some languages which got missed out, since I am not an expert in those languages so I kept them as it is. Once this is merged we can ask Adobe Localization team to verify translations for French and Japanese and the rest of the languages can be verified/corrected by community over time. |
swmitra
approved these changes
Jun 23, 2017
ficristo
pushed a commit
to quadre-code/quadre
that referenced
this pull request
Jan 13, 2019
Changed WebPlatform License to MDN License and respective strings
ficristo
pushed a commit
to quadre-code/quadre
that referenced
this pull request
Jan 13, 2019
Changed WebPlatform License to MDN License and respective strings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still need to get translations for some languages.