This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Add a post install 'cleanup' for thirdparty dependencies #13020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaggino
approved these changes
Jan 8, 2017
|
Sorry, I was busy and couldn't give this closer look, looks good. Merging |
|
No problem, thank you 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a revert of #12972 and it is similar of #12940 but instead of using npm from toplevel it uses the one in src.
After this, node dependencies should be added to the toplevel package.json, browser dependencies should be added to the package.json in src.
The copy:thirdparty grunt task should be used to filter the file we need in the browser.
I'm not particular happy with this, but using npm directly add a lot of files we don't need that will end in the final bundle.