Can't select text in Extension Manager anymore

[peterflynn]

Extension Manager shows an i-beam cursor, but you can't type any text.

This is a regression caused by #9226.

[peterflynn]

Unfortunately, there's no way to prevent focus without also preventing text selection, as far as I know, since preventDefault() on mousedown blocks them both.

So it looks like we'll have to go back to the old tabIndex code, which was removed by #9226 because it was causing #9196. I don't understand why it caused problems though -- in a simple JSFiddle test, tabIndex in no way prevents an unrelated <input> field from gaining focus on click. I couldn't find any mouse listeners in our code that would be blocking this either. Mysterious.

[peterflynn]

Ah, ok -- I think I understand this now. Bootstrap-modal doesn't actually support nested dialogs, but we'd been avoiding problems with its enforceFocus() code because the dialog's root element wasn't focusable (which broke enforceFocus(), happily in this case). Making the dialog focusable brings the buggy Bootstrap beahvior into play, though.

Seems like there are two options:
a) Avoid enforceFocus() bugginess -- either patch over it or stop using bootstrap-modal entirely (it doesn't buy us much at this point anyway). This would fix any other similar bugs that might occur with other nested dialogs, now and in the future.
b) Make Ctrl-Tab work even when document.body has focus, letting us revert to the old setup where the dialog root can't be focused. Easier & less invasive, but other nested dialogs could still get caught by this bug in the future, though.

[peterflynn]

I posted the safer "B" fix in PR #9522. Filed a spinoff bug #9524 for the larger Bootstrap cleanup issue.

[ingorichter]

@peterflynn I have merged #9522, can we now close this one?

[peterflynn]

Closing as fixed