Editor broken after trying to open large file

[peterflynn]

1. Try to open a large JS file (> 3 MB seems to do the trick)

Result: no code shown; gutter shows only line #1; editor background color only covers the top half of its area. Clicking anywhere in the editor throws "TypeError: Cannot call method 'chunkSize' of undefined".

Expected: file opens normally. I can open files up to at least 2.8 MB without a problem.

Worst case: if we absolutely can't open files beyond a certain size / line count / whatever, we should detect that, apologize, and then block CodeMirror from trying to load the text so we don't wind up showing broken UI.

[mikechambers]

fyi, I have a project where I need to sometimes open an 8 meg JSON file and search through it. Brackets chokes on it. Both TextMate and Sublime can handle it. TextMate has some delay while loading (and closing), Sublime shows a progress bar while it loads, and general performs well once it does load.

If you need a test case, you can grab the file from here:

https://github.com/mikechambers/SpectralKitten/blob/master/src/www/api/all_cards.json

[njx]

Assigning to Glenn to investigate. Is this a CodeMirror issue?

[gruehle]

This is a stack overflow exception in CodeMirror. Bug filed:
https://github.com/marijnh/CodeMirror2/issues/532

We could work around it by breaking large files into smaller chunks before inserting text into CodeMirror. I think we should wait to see if the CodeMirror bug gets fixed first, and fallback on splitting the file up as a last resort.

[gruehle]

Fixed with the latest CodeMirror merge. Setting FBNC and assigning to Peter for closing.

[peterflynn]

I've tested opening JS files up to 5 MB and it now works great. Not even that slow!