[UX] Move Find items to different menu?

[VizuaaLOG]

I noticed that find, find in files, find next and find previous are located in the edit menu. However, shouldn't it be in navigate because you are navigation the document for the inserted text?

If I'm wrong then sure but if not I could easily move the four items.

[peterflynn]

I believe it's a common convention on both Mac & Win to place Find-related menu items in the Edit menu -- unless there's specifically a Search menu, which we don't (yet) have. Is there an editor you're familiar with where search options are under Navigate instead of Edit?

[TomMalbran]

I think we should have a Search menu. The edit menu is getting long and lots of extensions add items there. I was planning on adding a Search menu in my Find in Files request (which also added a few extra commands). I might do it later as a separate request to start some discussion about it.

[VizuaaLOG]

@peterflynn No the other editor i use, notepad++, has it located under a search menu. I just though it would have more sense being under navigate.

[peterflynn]

Clarified title (was: "Find in Wrong Place")

[marcelgerber]

I checked back Notepad++ and SciTE. Both got own Search menus.
And notepad.exe (default Windows editor) got Search/Replace entries in the Edit menu (as Brackets currently does).

[njx]

Ultimately, we also want to have submenus, which would decrease the size of the Edit menu substantially (though I don't think we would move the Find items to a submenu, we would likely group some of the other less important commands into submenus). That might be a better solution.

Before deciding to move the Find items to a separate menu, I think we should figure out whether we're planning to do submenus anytime soon. See https://trello.com/c/EwLGRkYe/541-native-submenus and https://trello.com/c/OrIaeTsS/505-5-html-submenus.

Pinging @larz0 and @jadbox for opinions. Jonathan, do you think it's likely we would get to submenus soon? (We've wanted them in general for quite awhile since our menus are getting pretty long.) Larz, even if we had submenus, do you think we should consider adding a separate top level menu for search? (I'm not sure how many other search commands we would be likely to add over time.)

Tagging needs review to revisit once we've gotten Larz and Jonathan to weigh in.

[TomMalbran]

Besides the 5 search commands we currently have, I can think of 5 new commands that would be useful and even adding the "Find in ..." command as "Find in Selected File/Folder" to this new menu. One of the new commands would be a "Find in Working Set" and the 4 others would be to navigate through the Find in Files results, the commands mentioned here. 10 commands is a good number for a new Search menu.

The submenus would allow us to group the navigation commands, since I think that the main Find commands should be accessed from the main menu, which would reduce the size of the menu, but I find that a Search menu can be a better idea.

[njx]

I think it's likely that some of those commands would be unified into a single UI rather than having separate commands for all of them. But @larz0 and @peterflynn will be considering these issues as part of the upcoming find/replace revamp, so suggestions are welcome.

[TomMalbran]

Do you mean something like letting us select the scope for Find in Files in the search modal bar? This would mean that we can use just one command for all the Find in Files actions. Same with Find and Replace if they get unified. So we could end with just 2 main commands an a bunch of navigation commands that could end inside 1 or 2 submenus. That would work good too.

[njx]

To @larz0 to consider. Some mitigating factors: we'll have submenus in the future, which will make it easier for us to shorten the Edit menu by collapsing some of the other items in the menu together; we might not want more top-level menus. OTOH, many other editors have a separate top-level menu.

Larz, if you have any thoughts, make a recommendation and we can add a user story or roll it into one of the existing find/replace stories.

[larz0]

@njx if there's a substantial amount of items for Find/Replace then we should have a Find item on the top level.

E.g.

[larz0]

Reviewed.

[njx]

@larz0 If you unassign yourself from a bug, could you either assign it to someone on the dev team or set it to "needs review"? That way bugs don't start to slip through the cracks. Thanks.