Linux: Window doesn't close/quit on first click

[jasonsanjose]

On Ubuntu, when attempting to close the Brackets window via the X button, it takes 2 attempts before the window actually closes.

[timburgess]

I have done some investigation into this. It appears that earlier versions of the linux CEF3 didn't emit a GTK delete event - this has now been patched:
https://code.google.com/p/chromiumembedded/issues/attachmentText?id=780&aid=7800000000&name=gtk_delete_event.diff&token=-r_yEWKd9SaWYQGP9URC7I91jxI%3A1374642422808

The present code has a workaround which now that we are using patched CEF3 versions results in multiple clicks required.

[ChunkRadius]

Also having a similar problem with newly installed Sprint 32 (sprint 32 experimental build 0.32.0-9791 (On branch master,master e49a849) installed via deb package on Xubuntu 13.04. In fact, it's not closing at all. As a result, need to kill both brackets and brackets-node processes.

This didn't occur with Sprint 31 on the same system, so perhaps something's changed recently. Thanks!

[redmunds]

@dixonge The core team is short on native Linux skills. Would you like to try to fix this one?

[fakam]

Same thing on Ubuntu 13.10 / Mint 16 64bit

[jdittrich]

same here 12.04, Brackets 36

Are there any additional infos on that to ease the assessment of the problem for people who want to try to fix it? If I understand @timburgess correctly, the problem is caused by code in Brackets which was a workaround for a now-fixed bug in CEF?

[peterflynn]

Looks like someone should try uncommenting the disabled code in the Linux impl of CloseWindow(): https://github.com/adobe/brackets-shell/blob/master/appshell/appshell_extensions_gtk.cpp#L479

UPDATE: the "disabled code" referred to above now seems to be on a different line:
https://github.com/adobe/brackets-shell/blob/master/appshell/appshell_extensions_gtk.cpp#L531

Anyone want to give that a try and send a PR if it works?

[peterflynn]

Note: Dupe #5714 (or #7794) has some steps where this could cause data loss. Marking 'needs review' to consider whether the core team should take cycles to work on this.