File > New on collapsed folder fails

[peterflynn]

1. Collapse a folder and restart Brackets to make sure its contents haven't been loaded
2. Right-click the folder > New File

Result:
Throws exception. File name field never appears.

Expected:
Folder pops open and file name field appears. (This is how it works if the folder had previously been expanded in the same session).

[pthiess]

Reviewed

[gruehle]

FBNC @peterflynn

[peterflynn]

Confirmed fixed -- thanks Chema!

[jbalsas]

Hi, I've noticed this seems to have somehow regressed or stopped working.

I've tried to bisect to find the issue, but I haven't even been able to get it to work in the original merge to master, and a clean download of sprint18 doesn't work either.

Can someone verify this and reopen if necessary?

[peterflynn]

@jbalsas: it's working for me. Are you totally sure you're not pointing the shell at an old version of the src? (Or hit caching issues that make CEF think so? -- renaming the prefs folder is a good last resort to make sure stale cache is out of the question).

It's also possible there's some sort of timing-sensitive bug. What happens if you put a few breakpoints around the fix code from #2198?

[jbalsas]

@peterflynn Sorry for the late response, I'm running a little short on time these days ;)

I think I've finally managed to get what's going on. This is indeed an issue, and I can reproduce it when the folder where I want to create a file is empty. In that case, jstree is not dispatching the open_node.jstree event which is why the createNode method is never called. Could you verify this, please?

This may be related to #149, and triggering the event from there seems to solve this. Do you want me to open a separate issue to track this, or just submit the fix and point it here?