Skip to content
This repository was archived by the owner on Sep 2, 2021. It is now read-only.

Added support of Native Menus in Linux #602

Merged
merged 13 commits into from
May 3, 2017
Merged

Added support of Native Menus in Linux #602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
221b330
fix a memory leak
eyelash May 18, 2014
2216c01
linux-native-menus: implement separators
eyelash May 18, 2014
83f3748
linux-native-menus: use the native menu model
eyelash May 18, 2014
c47819f
linux-native-menus: implement the callback
eyelash May 18, 2014
04f56c7
linux-native-menus: position the items correctly
eyelash May 19, 2014
6c09c32
linux-native-menus: implement some more functions
eyelash May 25, 2014
354c10e
Merge branch 'linux-native-menus' of https://github.com/eyelash/brack…
ingorichter May 27, 2014
2f15dfd
Added support of native menu shortcuts in Linux
saurabh95 Apr 20, 2017
ff6abd4
Addressed review comments
saurabh95 Apr 24, 2017
0f67000
Added functionality of enabling and disabling menu items
saurabh95 Apr 24, 2017
98ccf5b
Code Cleanup
saurabh95 Apr 25, 2017
1524d7b
Addressed review comment
saurabh95 Apr 27, 2017
0ecc5c8
Addressed review comments
saurabh95 May 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions appshell/appshell_extensions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,6 +606,9 @@ class ProcessMessageDelegate : public ClientHandler::ProcessMessageDelegate {
bool enabled = argList->GetBool(2);
bool checked = argList->GetBool(3);
error = NativeMenuModel::getInstance(getMenuParent(browser)).setMenuItemState(command, enabled, checked);
if (error == NO_ERROR) {
error = SetMenuItemState(browser, command, enabled, checked);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to be common code (i.e. windows, mac and win).
Isn't the menu item state being set in line 608?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually NativeMenuModel::getInstance(getMenuParent(browser)).setMenuItemState(command, enabled, checked); does not work for Linux as it only sets a flag, so I have added SetMenuState function which is meant only for Linux and for case of Windows and MAC it is No Op

}
}
} else if (message_name == "SetMenuTitle") {
// Parameters:
Expand Down
Loading