Skip to content
This repository was archived by the owner on Sep 2, 2021. It is now read-only.

Replaced util macros in favour of cef_helpers|cef_logging ones #557

Merged
merged 2 commits into from
Jun 21, 2016
Merged

Replaced util macros in favour of cef_helpers|cef_logging ones #557

merged 2 commits into from
Jun 21, 2016

Conversation

ficristo
Copy link
Collaborator

And I removed the file since now it is unused.

@ficristo ficristo changed the title Replaced util macros in favour of cef_helpers ones Replaced util macros in favour of cef_helpers|cef_logging ones Jun 5, 2016
@ficristo
Copy link
Collaborator Author

/cc @ingorichter if you have a bit of time...

@nethip
Copy link
Contributor

nethip commented Jun 21, 2016

Great job @ficristo 👍 Really appreciate it!

@nethip
Copy link
Contributor

nethip commented Jun 21, 2016

I tried building remove-util branch on MAC and I am getting this error.

screen shot 2016-06-21 at 9 05 29 pm

@ficristo Could you have a look at this error?

@ficristo
Copy link
Collaborator Author

The defines to check the OS weren't working (not on OSX).
I tryed adding the cef_build or cef_task or cef_logging headers but it causes some problems on Windows.
I've copied the code to define the OS from the cef_build header, now it should work.

@nethip
Copy link
Contributor

nethip commented Jun 21, 2016

I am able to build this now on MAC.

@nethip nethip merged commit 15c0f8e into adobe:master Jun 21, 2016
@nethip
Copy link
Contributor

nethip commented Jun 21, 2016

Thanks @ficristo

@ficristo ficristo deleted the remove-util branch June 21, 2016 19:08
@core-ai-bot core-ai-bot mentioned this pull request Aug 17, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ficristo @nethip