This repository was archived by the owner on Sep 2, 2021. It is now read-only.
[Mac] Accept folder dropped on shell icon #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
@RaymondLim Done. |
This was referenced Oct 21, 2013
|
Merging now since we've already landed all other necessary changes to go with this pull request. |
RaymondLim
added a commit
that referenced
this pull request
Oct 22, 2013
[Mac] Accept folder dropped on shell icon
RaymondLim
added a commit
that referenced
this pull request
Dec 8, 2015
[Mac] Accept folder dropped on shell icon
This was referenced Aug 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have a JS-side implementation yet - this simply enables the Dock icon feedback and passes the path to openFile in application delegate. JS code currently merrily reports an error. I also plan to take a look at JS code.