Skip to content
This repository was archived by the owner on Sep 2, 2021. It is now read-only.

use g_spawn_command_line_async instead of execlp #319

Merged
merged 2 commits into from
Sep 17, 2013

Conversation

jasonsanjose
Copy link
Member

@macie After merging #317 I noticed in the execlp and execl docs http://linux.die.net/man/3/execlp...

The exec() family of functions replaces the current process image with a new process image

This didn't seem right to replace the brackets process with the browser. To avoid this, I moved to g_spawn_command_line_async https://developer.gnome.org/glib/2.34/glib-Spawning-Processes.html#g-spawn-command-line-async.

While cleaning that up, I also...

  • Changed CloseLiveBrowser to also kill the same set of browsers google-chrome, chromium, and chromium-browser
  • Fixed ShowFolderInOSWindow to use file: uris
  • Use g_get_user_config_dir instead of $HOME to get the correct config folder, see Follow XDG Base Directory Specification brackets#4932

@ghost ghost assigned ingorichter Sep 4, 2013
@pthiess
Copy link
Contributor

pthiess commented Sep 4, 2013

@ingorichter Hey Ingo, please take a look .

@jasonsanjose
Copy link
Member Author

@ingorichter pushed changes. Ready to review.

@jasonsanjose
Copy link
Member Author

Also fixes #4909

@jasonsanjose
Copy link
Member Author

Also fixes adobe/brackets#4909

ingorichter added a commit that referenced this pull request Sep 17, 2013
use g_spawn_command_line_async instead of execlp
@ingorichter ingorichter merged commit 753c225 into master Sep 17, 2013
@jasonsanjose jasonsanjose deleted the jasonsanjose/CloseLiveBrowser branch September 17, 2013 04:45
ingorichter added a commit that referenced this pull request Dec 8, 2015
use g_spawn_command_line_async instead of execlp
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants