Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduces Cognitive Complexity of search #554

Merged
merged 1 commit into from
Sep 4, 2021
Merged

Reduces Cognitive Complexity of search #554

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions assets/js/fastsearch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,31 +103,31 @@ document.onkeydown = function (e) {
}
} else if (current_elem) ae = current_elem;

if (key === "ArrowDown" && resultsAvailable && inbox) {
if (key === "Escape") {
reset()
} else if (!resultsAvailable || !inbox) {
return
} else if (key === "ArrowDown") {
e.preventDefault();
if (ae == sInput) {
// if the currently focused element is the search input, focus the <a> of first <li>
activeToggle(resList.firstChild.lastChild);
} else if (ae.parentElement == last) {
} else if (ae.parentElement != last) {
// if the currently focused element's parent is last, do nothing
} else {
// otherwise select the next search result
activeToggle(ae.parentElement.nextSibling.lastChild);
}
} else if (key === "ArrowUp" && resultsAvailable && inbox) {
} else if (key === "ArrowUp") {
e.preventDefault();
if (ae == sInput) {
// if the currently focused element is input box, do nothing
} else if (ae.parentElement == first) {
if (ae.parentElement == first) {
// if the currently focused element is first item, go to input box
activeToggle(sInput);
} else {
} else if (ae != sInput) {
// if the currently focused element is input box, do nothing
// otherwise select the previous search result
activeToggle(ae.parentElement.previousSibling.lastChild);
}
} else if (key === "ArrowRight" && resultsAvailable && inbox) {
} else if (key === "ArrowRight") {
ae.click(); // click on active link
} else if (key === "Escape") {
reset()
}
}