Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document twitter cards and open-graph support #513

Merged
merged 2 commits into from
Aug 22, 2021
Merged

Document twitter cards and open-graph support #513

merged 2 commits into from
Aug 22, 2021

Conversation

danielfdickinson
Copy link
Contributor

What does this PR change? What problem does it solve?

Fixes lack of documentation for Twitter Cards and Open-Graph metadata.

Was the change discussed in an issue or in the Discussions before?

#508

PR Checklist

  • I have enabled maintainer edits for this PR.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.

@adityatelange
Copy link
Owner

I understand documentation is needed for Twitter Cards and Open-Graph metadata.
But this PR is just explaining code, which just feels inappropriate to read.

@danielfdickinson
Copy link
Contributor Author

Okay. The image selection logic is kind of complex, so I need to think some more on how to explain that in a less 'code-like' way.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@danielfdickinson
Copy link
Contributor Author

Does this better suit the docs? (Also, if you wish I can squash, unless you prefer to do that when merging, assuming you do).

adityatelange
adityatelange approved these changes Aug 22, 2021
View reviewed changes
Copy link
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adityatelange adityatelange merged commit 5aa358c into adityatelange:exampleSite Aug 22, 2021
@adityatelange adityatelange added the documentation Improvements or additions to documentation label Aug 22, 2021
@danielfdickinson danielfdickinson deleted the pr-document-opengraph branch August 27, 2021 16:29
kylethedeveloper pushed a commit to kylethedeveloper/hugo-PaperMod that referenced this pull request Feb 21, 2023
@danielfdickinson
Document twitter cards and open-graph support (adityatelange#513)
67af21d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityatelange adityatelange adityatelange approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielfdickinson @adityatelange