Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow hiding author in post_meta #1250

Merged
merged 2 commits into from
Aug 5, 2023
Merged

feat: allow hiding author in post_meta #1250

merged 2 commits into from
Aug 5, 2023

Conversation

0x2E
Copy link
Contributor

@0x2E 0x2E commented Jun 30, 2023

What does this PR change? What problem does it solve?

For a person's site, in most cases the author is the person, and displaying it on every post and list may be redundant.

Setting the params.author in the configuration to empty will achieve the hidden effect, but it will also empty the value of <meta name="author">.

So add ShowAuthor.

Was the change discussed in an issue or in the Discussions before?

none

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

@0x2E
feat: allow hiding author in post_meta
ea64d8f 
For a person's site, in most cases the author is the person, and displaying it
on every post and list may be redundant.

Setting the `params.author` in the configuration to empty will achieve
the hidden effect, but it will also empty the value of `<meta name="author">`.

So add `ShowAuthor`.
adityatelange
adityatelange reviewed Jul 23, 2023
View reviewed changes
Copy link
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if we keep showing author by default.
To allow hiding of author (is user wants), instead of ShowAuthor, hideAuthor would be they key.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@0x2E
Copy link
Contributor Author

0x2E commented Jul 24, 2023

It has been renamed to hideAuthor.

@adityatelange adityatelange merged commit 1521cc7 into adityatelange:master Aug 5, 2023
romainx pushed a commit to romainx/hugo-PaperMod that referenced this pull request Aug 30, 2023
@0x2E @romainx
feat: allow hiding author in post_meta (adityatelange#1250)
c62ff13 
* feat: allow hiding author in post_meta

For a person's site, in most cases the author is the person, and displaying it
on every post and list may be redundant.

Setting the `params.author` in the configuration to empty will achieve
the hidden effect, but it will also empty the value of `<meta name="author">`.

So add hideAuthor
romainx pushed a commit to romainx/hugo-PaperMod that referenced this pull request Aug 30, 2023
@0x2E @romainx
feat: allow hiding author in post_meta (adityatelange#1250)
af43e52 
* feat: allow hiding author in post_meta

For a person's site, in most cases the author is the person, and displaying it
on every post and list may be redundant.

Setting the `params.author` in the configuration to empty will achieve
the hidden effect, but it will also empty the value of `<meta name="author">`.

So add hideAuthor
romainx pushed a commit to romainx/hugo-PaperMod that referenced this pull request Oct 30, 2023
@0x2E @romainx
feat: allow hiding author in post_meta (adityatelange#1250)
1193e7b 
* feat: allow hiding author in post_meta

For a person's site, in most cases the author is the person, and displaying it
on every post and list may be redundant.

Setting the `params.author` in the configuration to empty will achieve
the hidden effect, but it will also empty the value of `<meta name="author">`.

So add hideAuthor
romainx pushed a commit to romainx/hugo-PaperMod that referenced this pull request Dec 23, 2023
@0x2E @romainx
feat: allow hiding author in post_meta (adityatelange#1250)
562797e 
* feat: allow hiding author in post_meta

For a person's site, in most cases the author is the person, and displaying it
on every post and list may be redundant.

Setting the `params.author` in the configuration to empty will achieve
the hidden effect, but it will also empty the value of `<meta name="author">`.

So add hideAuthor
zer0ttl pushed a commit to zer0ttl/hugo-PaperMod that referenced this pull request Jan 24, 2024
@0x2E
feat: allow hiding author in post_meta (adityatelange#1250)
8f4f4b8 
* feat: allow hiding author in post_meta

For a person's site, in most cases the author is the person, and displaying it
on every post and list may be redundant.

Setting the `params.author` in the configuration to empty will achieve
the hidden effect, but it will also empty the value of `<meta name="author">`.

So add hideAuthor
romainx pushed a commit to romainx/hugo-PaperMod that referenced this pull request May 4, 2024
@0x2E @romainx
feat: allow hiding author in post_meta (adityatelange#1250)
6b16ccb 
* feat: allow hiding author in post_meta

For a person's site, in most cases the author is the person, and displaying it
on every post and list may be redundant.

Setting the `params.author` in the configuration to empty will achieve
the hidden effect, but it will also empty the value of `<meta name="author">`.

So add hideAuthor
romainx pushed a commit to romainx/hugo-PaperMod that referenced this pull request Jun 2, 2024
@0x2E @romainx
feat: allow hiding author in post_meta (adityatelange#1250)
8eefbf2 
* feat: allow hiding author in post_meta

For a person's site, in most cases the author is the person, and displaying it
on every post and list may be redundant.

Setting the `params.author` in the configuration to empty will achieve
the hidden effect, but it will also empty the value of `<meta name="author">`.

So add hideAuthor
romainx pushed a commit to romainx/hugo-PaperMod that referenced this pull request Jul 21, 2024
@0x2E @romainx
feat: allow hiding author in post_meta (adityatelange#1250)
f10895d 
* feat: allow hiding author in post_meta

For a person's site, in most cases the author is the person, and displaying it
on every post and list may be redundant.

Setting the `params.author` in the configuration to empty will achieve
the hidden effect, but it will also empty the value of `<meta name="author">`.

So add hideAuthor
jdxgfty pushed a commit to jdxgfty/hugo-PaperMod that referenced this pull request Nov 3, 2024
@0x2E
feat: allow hiding author in post_meta (adityatelange#1250)
9432258 
* feat: allow hiding author in post_meta

For a person's site, in most cases the author is the person, and displaying it
on every post and list may be redundant.

Setting the `params.author` in the configuration to empty will achieve
the hidden effect, but it will also empty the value of `<meta name="author">`.

So add hideAuthor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityatelange adityatelange adityatelange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x2E @adityatelange