Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add social icon for substack (#1129) #1197

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Add social icon for substack (#1129) #1197

merged 1 commit into from
Apr 23, 2023

Conversation

shivan-s
Copy link
Contributor

@shivan-s shivan-s commented Apr 22, 2023 •
edited
Loading

What does this PR change? What problem does it solve?

This adds Substack social icon. Here is some testing. Let me know what y'all think.

Screenshot 2023-04-22 at 3 21 04 PM
Screenshot 2023-04-22 at 3 21 32 PM

Was the change discussed in an issue or in the Discussions before?

Issue #1129. No discussion as far as I'm aware.

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@adityatelange adityatelange linked an issue Apr 23, 2023 that may be closed by this pull request
Substack Icon #1129
Closed
@adityatelange adityatelange added the icons Related to Icons label Apr 23, 2023
@adityatelange adityatelange merged commit a34784c into adityatelange:master Apr 23, 2023
romainx pushed a commit to romainx/hugo-PaperMod that referenced this pull request May 1, 2023
@shivan-s @romainx
Add social icon for substack (adityatelange#1197)
fbf4b8d
jdxgfty pushed a commit to jdxgfty/hugo-PaperMod that referenced this pull request Nov 3, 2024
@shivan-s
Add social icon for substack (adityatelange#1197)
04708ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityatelange adityatelange adityatelange approved these changes

Assignees
No one assigned
Labels
icons Related to Icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Substack Icon
2 participants
@shivan-s @adityatelange