Skip to content

Update: Make large and small properties optional (Fixes #116) #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

Update: Make large and small properties optional (Fixes #116) #117

merged 1 commit into from
Apr 28, 2025

Conversation

swashbuck
Copy link
Contributor

Fix #116

Fix

  • Make both _graphic.large and _graphic.small optional.

@swashbuck swashbuck self-assigned this Apr 23, 2025
@swashbuck swashbuck moved this from New to Needs Reviewing in adapt_framework: The TODO Board Apr 23, 2025
joe-allen-89
joe-allen-89 approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Apr 28, 2025
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@joe-allen-89 joe-allen-89 merged commit eaa1a67 into master Apr 28, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Apr 28, 2025
github-actions bot pushed a commit that referenced this pull request Apr 28, 2025
@semantic-release-bot
Chore(release): 6.3.1 [skip ci]
fc42270 
## [6.3.1](v6.3.0...v6.3.1) (2025-04-28)

### Fix

* Make large and small properties optional (fixes #117) ([eaa1a67](eaa1a67)), closes [#117](#117)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 6.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@swashbuck swashbuck

Labels
enhancement released
Projects
adapt_framework: The TODO Board
Status: Recently Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

large and small properties should be optional
4 participants
@swashbuck @oliverfoster @cahirodoherty-learningpool @joe-allen-89