Bundle code from container-utils
#300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slonopotamus
force-pushed
the
containers-utils-gone
branch
from
b22410c to
fcc2a0a
Compare
|
Actually, I've got a strong feeling that we already have other code that does almost everything these utils provide... |
|
Marking as draft, I want to simplify this even further. |
[container-utils](https://github.com/adamrehn/container-utils) 1. Isn't used by anyone except us 2. Isn't actively maintained 3. Forces `setuptools`/`wheel`/`twine` deps upon users 4. Overall, doesn't look like a valuable asset in itself This commit brings code from `container-utils` into ue4-docker repo and drops dependency on `container-utils`.
slonopotamus
force-pushed
the
containers-utils-gone
branch
from
492f0a5 to
10eb3b4
Compare
|
Done, this ended up to be much smaller. |
TBBle
reviewed
Mar 7, 2023
|
Looks good to me. For memory, some private projects were using the @slonopotamus lots of great refactoring happening lately (#297, #298, #299 and this), thanks for all your efforts here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
container-utils
setuptools/wheel/twinedeps upon usersThis commit brings code from
container-utilsinto ue4-docker repo and drops dependency oncontainer-utils.