Skip to content

fix: ensure copied source has correct ownership #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2022

Conversation

jlsalmon
Copy link
Contributor

@jlsalmon jlsalmon commented Apr 16, 2022

When using -layout and --opt source_mode=copy followed by docker build from inside a docker container (docker-in-docker) where the executing user is root, the copied source ends up being owned by root and the build fails during the Setup.sh phase due to permissions issues. This patch fixes the issue by ensuring the copied source is owned by the ue4 user.

Specifically, the error is the following:

chmod: changing permissions of 'bin/mcs': Operation not permitted
chmod: changing permissions of 'bin/xbuild': Operation not permitted
Fixing inconsistent case in filenames.
Setting up Mono
Checking dependencies...
Failed to write file '/home/ue4/UnrealEngine/.ue4dependencies.tmp': Access to the path "/home/ue4/UnrealEngine/.ue4dependencies.tmp" is denied.
Result: 1

When using `-layout` and `--opt source_mode=copy` followed by `docker build` from inside a docker container (docker-in-docker) where the executing user is `root`, the copied source ends up being owned by `root` and the build fails during the `Setup.sh` phase due to permissions issues. This patch fixes the issue by ensuring the copied source is owned by the `ue4` user.
@TBBle TBBle merged commit 2167c6e into adamrehn:master Apr 17, 2022
@TBBle
Copy link
Collaborator

TBBle commented Apr 17, 2022

Nice catch, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants