Add the ability to clone a specific commit of the Unreal Engine #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the
git clone
command in the ue4-source Dockerfiles with aninit
/fetch
/checkout
workflow, which makes it possible to clone specific commits using their commit hash. This is tremendously useful when building and testing container images for currently unreleased versions of the Unreal Engine (5.0 at the time of writing) where stability of the Engine's build health is not yet guaranteed and it may be necessary to select specific commits in order to ensure a successful build.The only potential issue with this change is that it alters the semantics of the
clone_opts
template option introduced in 46664f8, since the value of this option will now be passed togit fetch
rather thangit clone
and the overlap in supported flags between these two commands is not 100%.@slonopotamus what are your thoughts on this? Will the intended use case(s) for
clone_opts
still be satisfied by the flags supported bygit fetch
? If so, should we rename the template option tofetch_opts
to reflect this new placement, or leave the current name as-is?