fix(csv-stringify): update TS types to allow cast to return an object #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the enhancement. Could you remove the |
srmagura
force-pushed
the
stringify-cast-types
branch
from
9f671a5 to
7c2c8ce
Compare
|
Done. Out of curiosity, why are the |
Mostly for documentation purposes, if someone open the package.json file and try to understand the all mess of CJS, ESM, TS, ... his understanding is facilitated by the files being present. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #337.
When I built the codebase, it updated all of the compiled code which is tracked by git. I'm not sure if I was supposed to commit these changes.
My actual code changes are to:
packages/csv-stringify/lib/index.d.tspackages/csv-stringify/test/api.types.sync.ts