Skip to content

Update tud_hid_set_report_cb() report handling #9322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

dhalbert
Copy link
Collaborator

hathach/tinyusb#2253 changed the report_type value that is passed to tud_hid_set_report_cb(). Handle this change.

@dtcooper Could you test for your raw HID case? I tested this with keyboard and keyboard LED code, not raw HID. Thanks. The checks Summary page will include build artifacts.

@dtcooper
Copy link

dtcooper commented Jun 10, 2024

@dtcooper Could you test for your raw HID case? I tested this with keyboard and keyboard LED code, not raw HID. Thanks. The checks Summary page will include build artifacts.

Would be happy to, however having difficultly downloading from the "checks" – I click "Details" but can't seem to find a uf2 image. A direct link for the Raspberry Pi Pico build would help!

EDIT: I spoke a little too soon. Found it! Checking now.

@dtcooper
Copy link

dtcooper commented Jun 10, 2024

I confirm it works on the Raspberry Pi Pico!

dave@tomato:~$ hidapitester --usagePage 0xff00 --usage 1 --open -l 64 --send-output 2,3,4,5 --timeout 1000 --read-input 1
Opening device, vid/pid:0x0000/0x0000, usagePage/usage: FF00/1
Device opened
Writing output report of 64-bytes...wrote 64 bytes:
 02 03 04 05 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Reading 64-byte input report 0, 1000 msec timeout...read 64 bytes:
 01 03 04 05 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

(Output as expected using the code that reproduced the error as in the bug report)

dave@tomato:~$ cat /Volumes/CIRCUITPY/boot_out.txt
Adafruit CircuitPython 9.1.0-beta.3-27-g445adfdd59 on 2024-06-10; Raspberry Pi Pico with rp2040
Board ID:raspberry_pi_pico
UID:E66130100F755722
boot.py output:

Thanks!

@dhalbert
Copy link
Collaborator Author

Thanks for testing!

@hathach This fixes the issue I asked you about.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@tannewt tannewt merged commit e43270e into adafruit:main Jun 11, 2024
430 checks passed
@dhalbert dhalbert deleted the tinyusb-out-report-changes branch June 13, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raw HID [get_last_received_report()] broken on 9.1.0-beta.3 (Pi Pico rp2040)
3 participants