Update dependencies for RUSTSEC-2023-0052 #487
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appreciate the contribution, but doing this dependency update in a breaking manner isn't an acceptable way forward for this crate; the existing work in #480 has now been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Advisory
PR Checklist
Check your PR fulfills the following:
Overview
Due to the fact that it is a security vulnerability, this updates public dependencies (therefore includes breaking changes). Behavior is mostly the same, except that the error message now calls out that it's actix-tls that doesn't support non-hostnames, rather than rustls (now that that has been fixed). I also changed the
ErrorKindtoInvalidInput, as I believe that to be more accurate.I understand that it may be desirable for a number of reasons to update and finish #480 instead of merging this PR (feel free to close), but my personal opinion is that 4.0 is warranted.