Remove gulp-sass
; bump gulp
and tether
deps
#5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft
Leaving this as a draft until I can test it properly
Motivation
Allow leadconduit-client to use npm 9.
gulp-sass v2 is just not a feasible option with our modern hardware and runtimes. Installing it is impossible.
In addition: we have barely ever touched the CSS in this repo; we can just use the compiled CSS as a starting point, and modify as needed over time.
Description of the change
gulp-sass
.gulp-sass
is incredibly difficult to install with npm 9 and modern hardware..sass
files with their compiled.css
equivalents fromdist
gulp
to v4, and updateGulpfile
to reflect new syntaxtether
to 2.0.0tether
was also pinned togulp-sass
and other deprecated dependencies. Installing these were going to be a pain.[email protected]
removed gulp and other difficult dependencies, and according to the release notes does not introduce any breaking changes. Testing shall prove if this is correct or not!!!Type of change
Related tickets
https://app.shortcut.com/active-prospect/story/62992/update-client-to-node-18-npm-9
Checklists
Development and Testing
Code Review
Tracking
QA