Invalid version file after updating to 4.2.0

[eygraber]

Description:
After updating to 4.2.0 from 4.1.0 I get an error Invalid version file

Task version:
Specify the task version

Platform:

• Ubuntu
• macOS
• Windows

Runner type:

• Hosted
• Self-hosted

Repro steps:
eygraber/cmp-library-template#46

Expected behavior:
Not to have an error

Actual behavior:
There is an error

[gobetti]

the issue is that @eygraber 's example project uses a file called .ci-java-version, and setup-java@v4.2.0 no longer accepts that, as stated in the updated readme:

Supported files are .java-version and .tool-versions.

respective code change: https://github.com/actions/setup-java/pull/606/files#diff-8164d45a0a98040cbf5161c5b6e696920163460bea5f24100a7a01720c4a9a91R125267-R125276

I think for that change not to be a breaking change and require a bump to v5, we could keep the java-version-file parameter doing what it did before, and specifically work like a .java-version file should; that name is also more indicative of a ".java-version file" and one might not expect to use "java-version-file" to point to a "tool versions file"

[jamessmckay]

I use a .java-version file and I get the same error. Reverting to 4.1.0 works fine.

[gobetti]

@jamessmckay yeah 4.2.0 is only working for me if my file is called .java-version and I specify java-version-file: .java-version

[eddsteel]

Also getting this error with ./.java-version. The workaround to use .java-version isn't really going to work because we use a shared action with inputs to call this one with java-version-file: ${{ inputs.working-directory }}/.java-version.

Is it intended to only support a version file in the root of the repo? It isn't really mentioned in the linked doc change.

[HarithaVattikuti]

Hello @eygraber
Thank you for creating this issue. We will investigate it and get back to you as soon as we have some feedback.

[jamessmckay]

@eddsteel we also use a shared action for our java implementation and we pass in ./.java-version to as a parameter.

[buckett]

I think for that change not to be a breaking change and require a bump to v5, we could keep the java-version-file parameter doing what it did before, and specifically work like a .java-version file should; that name is also more indicative of a ".java-version file" and one might not expect to use "java-version-file" to point to a "tool versions file"

If the idea is that it only supports files in the root then that seems like a breaking change and something that should be a major version bump.

[gobetti]

@buckett I don't think that was the idea

[parsable-danielmillen]

the issue is that @eygraber 's example project uses a file called .ci-java-version, and setup-java@v4.2.0 no longer accepts that, as stated in the updated readme:

@gobetti Even with the change as was expected it should have been part of a major version bump because that was also a breaking change.

[gobetti]

@parsable-danielmillen to clarify to all, I haven't contributed to this repo, I was affected by the bug just like y'all but seeing this fresh issue made me want to contribute in finding what went wrong and possible workarounds we have, so perhaps someone more familiar with the project can use that to make a more informed decision. It's clearly a breaking change that it no longer accepts something it did. But as for the original expectation, my interpretation is that they tried to allow something extra (.tool-versions), and if you mean that'd be a breaking change too, you might want to detail given the acceptance of that change may indicate not everybody sees it. Thanks!