Clean up import list #645
Merged
Clean up import list #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #644
Closed
sledigabel
reviewed
Jun 22, 2021
| @@ -21,7 +21,7 @@ _Default values are the defaults set in the charts values.yaml, some properties | |||
| | `authSecret.github_app_installation_id` | The ID of your GitHub App installation. **This can't be set at the same time as `authSecret.github_token`** | | | |||
| | `authSecret.github_app_private_key` | The multiline string of your GitHub App's private key. **This can't be set at the same time as `authSecret.github_token`** | | | |||
| | `authSecret.github_token` | Your chosen GitHub PAT token. **This can't be set at the same time as the `authSecret.github_app_*`** | | | |||
| | `image.repository` | The "repository/image" of the controller container | summerwind/actions-runner-controller | | |||
| | `image.repository` | The "repository/image" of the controller container | actions-runner-controller/actions-runner-controller | | |||
There was a problem hiding this comment.
I do not think that one needs changing? This is the container image that will run the controller right?
sledigabel
reviewed
Jun 22, 2021
| @@ -26,7 +26,7 @@ authSecret: | |||
| #github_token: "" | |||
|
|
|||
| image: | |||
| repository: summerwind/actions-runner-controller | |||
| repository: actions-runner-controller/actions-runner-controller | |||
There was a problem hiding this comment.
Same as above, not sure that one needs changing?
There was a problem hiding this comment.
@sledigabel Ah, sorry I missed your comments! Thanks- I'm fixing the two issues in #663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #644