bug-fix: patched dir owned by runner #284
Conversation
|
commit e719724 added so that images are always built using the latest possible actions/runner release. could be nice to build this daily so no need to keep bumping the version |
runner/Dockerfile
Outdated
| @@ -1,7 +1,6 @@ | |||
| FROM ubuntu:18.04 | |||
|
|
|||
| ARG TARGETPLATFORM | |||
| ARG RUNNER_VERSION=2.274.2 | |||
There was a problem hiding this comment.
Thanks for the fix! But could we keep this build-arg as this is required to inject the runner version from within our github actions workflow?
There was a problem hiding this comment.
could be nice to build this daily so no need to keep bumping the version
Sorry I missed your comment. I got your intention, but doing so would prevent us from tagging container images with their RUNNER_VERSION.
I'd certainly investigate a way to automate it, probably reusing your snippet for getting the latestest available runner version. But it should be done in a separate PR so that we're sure we don't break anything.
There was a problem hiding this comment.
LGTM on the --chown addition. Also, please allow me to replicate the same fix onto the dockerd-within-runner-container variant of your Dockerfile too!
Thanks for your contribution, @alex-mozejko
This reverts commit e719724ae9fe92a12d4a087185cf2a2ff543a0dd.
in relation to:
#283