Added Pagination in activity screen. #3148
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anisha-e10
changed the title
|
Hey there 👋,
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3148 +/- ##
==========================================
+ Coverage 46.76% 47.13% +0.37%
==========================================
Files 948 948
Lines 57845 57870 +25
==========================================
+ Hits 27049 27278 +229
+ Misses 30796 30592 -204
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anisha-e10
commented
Jun 30, 2025
app/lib/features/activities/providers/activities_providers.dart
Outdated
Show resolved
Hide resolved
anisha-e10
commented
Jun 30, 2025
app/lib/features/activities/providers/activities_providers.dart
Outdated
Show resolved
Hide resolved
gtalha07
reviewed
Jul 1, 2025
gtalha07
reviewed
Jul 1, 2025
app/lib/features/activities/providers/activities_providers.dart
Outdated
Show resolved
Hide resolved
gtalha07
reviewed
Jul 1, 2025
There was a problem hiding this comment.
I can't explicitly approve here because of how the providers are used to accomodate loading and pagination as they always seem abhorrent to mess with UI states (from the past experience) though I see it works based on the provided video. Perhaps @kumarpalsinh25 or @gnunicorn could also give opinions on taken approach...
kumarpalsinh25
requested changes
Jul 3, 2025
app/lib/features/activities/providers/activities_providers.dart
Outdated
Show resolved
Hide resolved
app/lib/features/activities/providers/activities_providers.dart
Outdated
Show resolved
Hide resolved
app/lib/features/activities/providers/activities_providers.dart
Outdated
Show resolved
Hide resolved
app/lib/features/activities/providers/notifiers/activities_notifiers.dart
Outdated
Show resolved
Hide resolved
…3 into anisha/activity-pagination
… anisha/activity-pagination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3146
This PR adds pagination support for activity items. The first 100 items are loaded initially, and an additional 100 items are fetched when the user scrolls to the end of the list.
A loading indicator is displayed at the bottom while new items are being loaded.
Reference video:
Screen.Recording.2025-06-30.at.1.15.12.PM.mov