Skip to content

Appflowy Codeblocks #3047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Appflowy Codeblocks #3047

wants to merge 8 commits into from

Conversation

gnunicorn
Copy link
Contributor

This brings code-block support to our internal appflowy editor.

  • import plugin code base into our repo
  • upgrade plugin code base to work with our latest appflowy version
  • clean up design to make it more concise and take up less space (move overlayer into stack on the right side)
  • fix expansion issue
    the editor isn't properly expanding when we insert a code block
  • fix paste-into block issue
    it currently flows over the codeblock upon paste
  • fix inline-enter issue
    on desktop you can't properly enter in the code unless because of our enter-to-submit trap around it (which should probably become smarter itself)

Superseeds #2691

@github-project-automation github-project-automation bot moved this to Backlog in Product Jun 1, 2025
@gnunicorn gnunicorn added the c-html-editor Appflowy Editor aspects label Jun 1, 2025
@gnunicorn gnunicorn moved this from Backlog to In progress in Product Jun 1, 2025
@gnunicorn gnunicorn added this to the Chat NG switch-over milestone Jun 1, 2025
Copy link
Contributor

github-actions bot commented Jun 1, 2025

Hey there 👋,
and thanks for the contribution. But it seems like you forgot to

  • 📰 Add a markdown file in .changes/ explaining what changed

Copy link

codecov bot commented Jun 1, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 43.75%. Comparing base (ec7bbe4) to head (f92a143).

Files with missing lines Patch % Lines
...pp/lib/common/widgets/html_editor/html_editor.dart 75.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3047      +/-   ##
==========================================
- Coverage   43.85%   43.75%   -0.10%     
==========================================
  Files         901      901              
  Lines       56658    56676      +18     
==========================================
- Hits        24847    24800      -47     
- Misses      31811    31876      +65     
Flag Coverage Δ
integration-test 51.04% <ø> (-0.26%) ⬇️
unittest 33.68% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-html-editor Appflowy Editor aspects
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

1 participant