-
-
Notifications
You must be signed in to change notification settings - Fork 21
Autofill added for recovery key in onboarding. #2990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2990 +/- ##
==========================================
- Coverage 41.84% 41.84% -0.01%
==========================================
Files 887 891 +4
Lines 55911 56091 +180
==========================================
+ Hits 23395 23470 +75
- Misses 32516 32621 +105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@anisha-e10 so will this only work if the user clicked into any of the fields? I doubt that they will be doing that .... can we auto-focus so they don't have to click? and there is no way we can just close the keyboard again if they click it? It seems pointless to have it shown at all, though we "need" it for the emulation, I'd rather not have the user distracted by it too much... |
@gnunicorn Here, how the autofocus will work Screen.Recording.2025-05-20.at.5.41.16.PM.mov |
…ption-key # Conflicts: # app/lib/l10n/app_en.arb
This PR introduces two key improvements to the onboarding experience:
🔧 Changes
1. Autofill for Recovery Key
2. Hide Indicator on Keyboard Open
Reference image:
Reference video :
Screen.Recording.2025-05-20.at.11.59.25.AM.mov
Reference video (Hide indicator while keyboard is open):
Screen.Recording.2025-05-20.at.12.28.25.PM.mov