Skip to content

Autofill added for recovery key in onboarding. #2990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

anisha-e10
Copy link
Contributor

@anisha-e10 anisha-e10 commented May 20, 2025

This PR introduces two key improvements to the onboarding experience:

  1. Autofill Support for Recovery Key
  2. UI Fix: Hide Indicator When Keyboard is Open

🔧 Changes

1. Autofill for Recovery Key

  • Enables integration with the system’s default password manager like login and registration, users are prompted to save the recovery key via their password manager.

2. Hide Indicator on Keyboard Open

  • In the onboarding screen, the visual indicator is now hidden when the on-screen keyboard appears.
  • This prevents layout overlap and improves clarity for users interacting with input fields.

Reference image:

Screenshot 2025-05-20 at 11 44 37 AM

Reference video :

Screen.Recording.2025-05-20.at.11.59.25.AM.mov

Reference video (Hide indicator while keyboard is open):

Screen.Recording.2025-05-20.at.12.28.25.PM.mov

Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 25.54348% with 137 lines in your changes missing coverage. Please review.

Project coverage is 41.84%. Comparing base (b2af114) to head (e30f972).
Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
app/lib/features/showcases/routes.dart 0.00% 46 Missing ⚠️
.../features/showcases/pages/one_step_onboarding.dart 0.00% 35 Missing ⚠️
...b/features/showcases/pages/showcase_list_page.dart 0.00% 21 Missing ⚠️
...atures/onboarding/pages/encrption_backup_page.dart 63.63% 16 Missing ⚠️
...ckup_feature/widgets/encryption_backup_widget.dart 0.00% 5 Missing ⚠️
...eatures/analytics/pages/analytics_opt_in_page.dart 20.00% 4 Missing ⚠️
app/lib/features/auth/pages/login_page.dart 0.00% 3 Missing ⚠️
app/lib/features/home/pages/dashboard.dart 0.00% 3 Missing ⚠️
...lib/features/onboarding/pages/onboarding_page.dart 84.21% 3 Missing ⚠️
...pp/lib/router/shell_routers/home_shell_router.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2990      +/-   ##
==========================================
- Coverage   41.84%   41.84%   -0.01%     
==========================================
  Files         887      891       +4     
  Lines       55911    56091     +180     
==========================================
+ Hits        23395    23470      +75     
- Misses      32516    32621     +105     
Flag Coverage Δ
integration-test 50.35% <ø> (+0.09%) ⬆️
unittest 31.35% <25.54%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anisha-e10 anisha-e10 marked this pull request as ready for review May 20, 2025 08:08
@gnunicorn
Copy link
Contributor

@anisha-e10 so will this only work if the user clicked into any of the fields? I doubt that they will be doing that .... can we auto-focus so they don't have to click?

and there is no way we can just close the keyboard again if they click it? It seems pointless to have it shown at all, though we "need" it for the emulation, I'd rather not have the user distracted by it too much...

@anisha-e10
Copy link
Contributor Author

@anisha-e10 so will this only work if the user clicked into any of the fields? I doubt that they will be doing that .... can we auto-focus so they don't have to click?

@gnunicorn Here, how the autofocus will work

Screen.Recording.2025-05-20.at.5.41.16.PM.mov

@anisha-e10 anisha-e10 marked this pull request as draft May 22, 2025 08:22
@gnunicorn gnunicorn mentioned this pull request May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

2 participants