Skip to content

fix: split the healthcheck and external Node Ping paths (resolve #2042) #2152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 25, 2024
Merged

fix: split the healthcheck and external Node Ping paths (resolve #2042) #2152

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
11f73f1
ci: :construction_worker: changed internal healthcheck path
marvinroman Feb 29, 2024
cbe68db
fix: create maintance mode exception paths that will bypass maintenan…
marvinroman Feb 29, 2024
a90c663
ci: :construction_worker: added vite build to container
marvinroman Mar 1, 2024
29720e3
build: :construction_worker: removed npm build since it is redundant
marvinroman Mar 25, 2024
274316a
Merge branch 'dev' into 2131-latest-compiled-component-path-not-found
jobara Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .kube/app/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ COPY . $APP_DIR

RUN composer install

RUN . "$NVM_DIR/nvm.sh" && nvm use $NODE_VERSION && npm ci
RUN . "$NVM_DIR/nvm.sh" && nvm use $NODE_VERSION && npm ci && npm run build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marvinroman this is interesting because there is a post install script in the package.json file; which should be running npm run build. When I run npm ci locally, the build is also run. Can you see if the build is run as part of the post install in docker? Maybe something isn't working or maybe something else is at play.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jobara I have removed.

I can confirm that the build directory was mapped into the running container which probably caused the anomaly in my local environment.


RUN chown -R www-data:root $APP_DIR/public/ $NVM_DIR

Expand Down
3 changes: 2 additions & 1 deletion .kube/app/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
name: "IRIS Accessibility Exchange"
health: /
health: /status/db
nodeHealth: /
cronjobs:
- name: schedule
schedule: "* * * * *"
Expand Down
3 changes: 2 additions & 1 deletion app/Http/Middleware/PreventRequestsDuringMaintenance.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ class PreventRequestsDuringMaintenance extends Middleware
* @var array<int, string>
*/
protected $except = [
//
'/status/db',
'/status',
];
}