Skip to content

fix: remove unneeded CSRF token on resource collection search form #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented Jun 14, 2023

@sbates-idrc identified the presence of an unneeded CSRF token in a search form. This PR removes it.

Prerequisites

If this PR changes PHP code or dependencies:

  • I've run composer format and fixed any code formatting issues.
  • I've run composer analyze and addressed any static analysis issues.
  • I've run php artisan test and ensured that all tests pass.
  • I've run composer localize to update localization source files and committed any changes.

If this PR changes CSS or JavaScript code or dependencies:

  • I've run npm run lint and fixed any linting issues.
  • I've run npm run build and ensured that CSS and JavaScript assets can be compiled.

@greatislander greatislander self-assigned this Jun 14, 2023
@greatislander greatislander added the bug Something isn't working label Jun 14, 2023
@greatislander greatislander requested a review from jobara June 14, 2023 14:47
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #1798 (99cae35) into dev (40facf5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #1798   +/-   ##
=========================================
  Coverage     96.47%   96.47%           
  Complexity     1984     1984           
=========================================
  Files           299      299           
  Lines          8636     8636           
=========================================
  Hits           8332     8332           
  Misses          304      304           

@jobara jobara enabled auto-merge (squash) June 14, 2023 15:27
@jobara jobara merged commit 37e733c into dev Jun 14, 2023
@jobara jobara deleted the fix/remove-unneeded-csrf-token branch June 14, 2023 15:27
@jobara jobara added this to the 1.0.0 milestone Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants