Skip to content

fix: individual page validation messages (resolves #1751, #1752) #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

jobara
Copy link
Collaborator

@jobara jobara commented Jun 7, 2023

Resolves #1751
Resolves #1752

  • Single validation message for missing bio
  • Replace "region" with "provinces and territories" in validation message for missing region

Prerequisites

If this PR changes PHP code or dependencies:

  • I've run composer format and fixed any code formatting issues.
  • I've run composer analyze and addressed any static analysis issues.
  • I've run php artisan test and ensured that all tests pass.
  • I've run composer localize to update localization source files and committed any changes.

If this PR changes CSS or JavaScript code or dependencies:

  • I've run npm run lint and fixed any linting issues.
  • I've run npm run build and ensured that CSS and JavaScript assets can be compiled.

@jobara jobara added this to the 1.0.0 milestone Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #1767 (bedbb7a) into dev (974f3d4) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                dev    #1767   +/-   ##
=========================================
  Coverage     96.47%   96.47%           
  Complexity     1984     1984           
=========================================
  Files           299      299           
  Lines          8620     8620           
=========================================
  Hits           8316     8316           
  Misses          304      304           
Impacted Files Coverage Δ
app/Http/Requests/UpdateIndividualRequest.php 100.00% <100.00%> (ø)
app/Http/Requests/UpdateProjectRequest.php 100.00% <100.00%> (ø)

@jobara jobara merged commit 61e8b84 into accessibility-exchange:dev Jun 7, 2023
marvinroman pushed a commit to marvinroman/platform that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Creating individual page - Error message for bio Creating individual page - error message for province or territory
1 participant