Skip to content

Add FileName for RemoteStreamContent #9426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 28, 2021
Merged

Add FileName for RemoteStreamContent #9426

merged 6 commits into from
Jun 28, 2021

Conversation

JadynWong
Copy link
Contributor

@JadynWong JadynWong commented Jun 24, 2021 •
edited
Loading

Add FileName for RemoteStreamContent

  • Download file with file name.
  • Upload file with file name.

@realLiangshiwei realLiangshiwei requested a review from maliming June 25, 2021 01:01
@realLiangshiwei realLiangshiwei added this to the 4.4-final milestone Jun 25, 2021
@JadynWong
Copy link
Contributor Author

JadynWong commented Jun 25, 2021 •
edited
Loading

RemoteStreamContent as a stream content. I think the ContentType property of RemoteStreamContent should use application/octet-stream as the default value.

applicationoctet-stream

What do you think?

@maliming maliming merged commit 821c089 into abpframework:dev Jun 28, 2021
@maliming maliming modified the milestones: 4.4-final, 4.4-preview Jun 28, 2021
@maliming
Copy link
Member

Thanks @JadynWong 👍

@JadynWong JadynWong deleted the jadyn/RemoteStreamContent-Improvement branch June 28, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliming maliming maliming approved these changes

Assignees
No one assigned
Labels
abp-framework
Projects
None yet
Milestone
4.4-preview
Development

Successfully merging this pull request may close these issues.
3 participants
@JadynWong @maliming @realLiangshiwei